You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/09/13 09:51:29 UTC

Review Request 25609: ProcessInstanceResumeTest and ProcessInstanceSuspendTest as per FALCON-166

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25609/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-723
    https://issues.apache.org/jira/browse/FALCON-723


Repository: falcon-git


Description
-------

Post FALCON-166 api/instance/status does not has checks on start and end time. Changing tests for this.


Diffs
-----

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 2e774c2 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 32759a0 

Diff: https://reviews.apache.org/r/25609/diff/


Testing
-------

ProcessInstanceResumeTest#testProcessInstanceResumeOnlyEnd
ProcessInstanceResumeTest#testProcessInstanceResumeNoParams
ProcessInstanceSuspendTest#testProcessInstanceSuspendWoParams


Thanks,

Ruslan Ostafiychuk


Re: Review Request 25609: ProcessInstanceResumeTest and ProcessInstanceSuspendTest as per FALCON-166

Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25609/#review53273
-----------------------------------------------------------

Ship it!


Ship It!

- Raghav Gautam


On Sept. 13, 2014, 2:43 a.m., Ruslan Ostafiychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25609/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 2:43 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-723
>     https://issues.apache.org/jira/browse/FALCON-723
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Post FALCON-166 api/instance/status does not has checks on start and end time. Changing tests for this.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 2e774c2 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 32759a0 
> 
> Diff: https://reviews.apache.org/r/25609/diff/
> 
> 
> Testing
> -------
> 
> ProcessInstanceResumeTest#testProcessInstanceResumeOnlyEnd
> ProcessInstanceResumeTest#testProcessInstanceResumeNoParams
> ProcessInstanceSuspendTest#testProcessInstanceSuspendWoParams
> ProcessInstanceSuspendTest#testProcessInstanceSuspendLargeRange
> 
> 
> Thanks,
> 
> Ruslan Ostafiychuk
> 
>


Re: Review Request 25609: ProcessInstanceResumeTest and ProcessInstanceSuspendTest as per FALCON-166

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25609/
-----------------------------------------------------------

(Updated Sept. 13, 2014, 9:43 a.m.)


Review request for Falcon.


Bugs: FALCON-723
    https://issues.apache.org/jira/browse/FALCON-723


Repository: falcon-git


Description
-------

Post FALCON-166 api/instance/status does not has checks on start and end time. Changing tests for this.


Diffs
-----

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 2e774c2 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 32759a0 

Diff: https://reviews.apache.org/r/25609/diff/


Testing (updated)
-------

ProcessInstanceResumeTest#testProcessInstanceResumeOnlyEnd
ProcessInstanceResumeTest#testProcessInstanceResumeNoParams
ProcessInstanceSuspendTest#testProcessInstanceSuspendWoParams
ProcessInstanceSuspendTest#testProcessInstanceSuspendLargeRange


Thanks,

Ruslan Ostafiychuk


Re: Review Request 25609: ProcessInstanceResumeTest and ProcessInstanceSuspendTest as per FALCON-166

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25609/
-----------------------------------------------------------

(Updated Sept. 13, 2014, 9:42 a.m.)


Review request for Falcon.


Bugs: FALCON-723
    https://issues.apache.org/jira/browse/FALCON-723


Repository: falcon-git


Description
-------

Post FALCON-166 api/instance/status does not has checks on start and end time. Changing tests for this.


Diffs (updated)
-----

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 2e774c2 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 32759a0 

Diff: https://reviews.apache.org/r/25609/diff/


Testing
-------

ProcessInstanceResumeTest#testProcessInstanceResumeOnlyEnd
ProcessInstanceResumeTest#testProcessInstanceResumeNoParams
ProcessInstanceSuspendTest#testProcessInstanceSuspendWoParams


Thanks,

Ruslan Ostafiychuk


Re: Review Request 25609: ProcessInstanceResumeTest and ProcessInstanceSuspendTest as per FALCON-166

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25609/
-----------------------------------------------------------

(Updated Sept. 13, 2014, 9:31 a.m.)


Review request for Falcon.


Bugs: FALCON-723
    https://issues.apache.org/jira/browse/FALCON-723


Repository: falcon-git


Description
-------

Post FALCON-166 api/instance/status does not has checks on start and end time. Changing tests for this.


Diffs
-----

  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceResumeTest.java 2e774c2 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceSuspendTest.java 32759a0 

Diff: https://reviews.apache.org/r/25609/diff/


Testing
-------

ProcessInstanceResumeTest#testProcessInstanceResumeOnlyEnd
ProcessInstanceResumeTest#testProcessInstanceResumeNoParams
ProcessInstanceSuspendTest#testProcessInstanceSuspendWoParams


Thanks,

Ruslan Ostafiychuk