You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Peter Roßbach <pr...@objektpark.de> on 2010/04/27 15:40:31 UTC
Re: .classpath and .project in src distribution (was: svn commit: r937993)
The current setup of the .project and .classpath files works good for
many years.
I think it was helpfull for user of the src distribution, also use the
correct eclipse setup.
The license issue is really bad and we must fixit! We can do that with
a little ant task.
To move .project and .classpath to temp files.
+1
Can we use eclipse.project.default and eclispe.classpath.default as
names?
Peter
Am 27.04.2010 um 09:18 schrieb Konstantin Kolinko:
> 2010/4/26 <pe...@apache.org>:
>> Author: pero
>> Date: Mon Apr 26 10:46:01 2010
>> New Revision: 937993
>>
>> URL: http://svn.apache.org/viewvc?rev=937993&view=rev
>> Log:
>> Include .project and .classpath files to src distribution.
>> s. http://ant.apache.org/manual/dirtasks.html#defaultexcludes to
>> not include scm files!
>>
>
> The ".project" and ".classpath" files do not have ASL header. I do not
> think that we should include them in the src distribution how they
> are.
>
> Eclipse IDE overwrites them from time to time, so keeping a header in
> them looks like a lot of work, e.g. we did that once already:
> http://svn.apache.org/viewvc?view=revision&revision=746405
>
> One way to deal with it could be to make a copy of them under
> different names, e.g.
> ".classpath.tmpl.xml, ".project.tmpl.xml", and ignore existing
> ".classpath" and ".project":
> http://subversion.apache.org/faq.html#ignore-commit
>
> What do you think?
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: .classpath and .project in src distribution (was: svn commit:
r937993)
Posted by Mark Thomas <ma...@apache.org>.
On 29/04/2010 00:46, Mark Thomas wrote:
> Having read the thread and thought about it some more, I think there is
> consensus to do the following:
> - Rename the current .classpath and .project to eclipse.classpath &
> eclipse.project
> - Include these renamed files in the src distros
> - Exclude .classpath and .project from src distos
> - Exclude .classpath, .project and any other Eclipse files from svn
>
> Assuming there are no objections, I will make the necessary changes to
> trunk, 6.0.x and 5.5.x in a couple of days.
Done.
The 5.5.x sample files probably need some tweaks. I went with what I use
at the momeent but that might not suit everyone.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: .classpath and .project in src distribution (was: svn commit:
r937993)
Posted by Mark Thomas <ma...@apache.org>.
On 27/04/2010 08:40, Peter Roßbach wrote:
> The current setup of the .project and .classpath files works good for
> many years.
> I think it was helpfull for user of the src distribution, also use the
> correct eclipse setup.
I agree these are a useful starting point however, there are many
legitimate reasons why users (and ocmmitters) may want to use modified
versions. It annoys me on a regular basis that I have to avoid checking
in modified versions of these files.
> The license issue is really bad and we must fixit! We can do that with a
> little ant task.
I don't think the license issue is a big deal. If we decide to change
things and we have an opportunity to add license headers then we should
do so but I don't think it should be the primary aim.
> To move .project and .classpath to temp files.
> +1
>
> Can we use eclipse.project.default and eclispe.classpath.default as names?
Having read the thread and thought about it some more, I think there is
consensus to do the following:
- Rename the current .classpath and .project to eclipse.classpath &
eclipse.project
- Include these renamed files in the src distros
- Exclude .classpath and .project from src distos
- Exclude .classpath, .project and any other Eclipse files from svn
Assuming there are no objections, I will make the necessary changes to
trunk, 6.0.x and 5.5.x in a couple of days.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org