You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "f1amingo (via GitHub)" <gi...@apache.org> on 2026/09/14 12:11:43 UTC
[PR] [ISSUE #11163] Fix lite topic prefix index not maintained on first message [rocketmq]
f1amingo opened a new pull request, #11164:
URL: https://github.com/apache/rocketmq/pull/11164
### Which Issue(s) This PR Fixes
- Fixes #11163
### Brief Description
The lite topic prefix index is maintained only when the dispatcher sees offset == 0, but the message-arriving notification carries logicOffset = queueOffset + 1, so the first message of a lite topic arrives with offset == 1. The create hook thus never fires at runtime, and lite topics created after startup are missing from wildcard dispatch and parent-topic collect/count/clean until the broker restarts. This PR corrects the comparison to offset == 1 and restores the store-dependent lifecycle tests to the concrete impl test classes (file CQ and RocksDB CQ), driving the index through the real putMessage -> notify -> dispatch path so this behavior is covered.
### How Did You Test This Change?
Unit tests in LiteLifecycleManagerTest (file CQ) and RocksDBLiteLifecycleManagerTest (RocksDB CQ) wire a real MessageArrivingListener + LiteEventDispatcher and assert collectByParentTopic / getLiteTopicCount / cleanByParentTopic against real putMessage. Before the fix they fail with an empty index; after the fix the lite test package passes (19 run, 0 failures). Checkstyle clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11163] Fix lite topic prefix index not maintained on first message [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11164:
URL: https://github.com/apache/rocketmq/pull/11164#issuecomment-5664092020
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11164?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 49.36%. Comparing base ([`923a80e`](https://app.codecov.io/gh/apache/rocketmq/commit/923a80e9f49cf79b3424efb3228c602afb46c35b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d30fdd`](https://app.codecov.io/gh/apache/rocketmq/commit/8d30fddd74d385e36bdd2db6fc25f2db805de0d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #11164 +/- ##
=============================================
- Coverage 49.42% 49.36% -0.07%
+ Complexity 14246 14227 -19
=============================================
Files 1390 1390
Lines 103132 103132
Branches 13485 13485
=============================================
- Hits 50969 50906 -63
- Misses 45997 46051 +54
- Partials 6166 6175 +9
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11164?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11163] Fix lite topic prefix index not maintained on first message [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #11164:
URL: https://github.com/apache/rocketmq/pull/11164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org