You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/03/26 04:00:59 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #1678: Close zkClients created by TaskStateModelFactory

jiajunwang commented on a change in pull request #1678:
URL: https://github.com/apache/helix/pull/1678#discussion_r602000734



##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java
##########
@@ -148,6 +134,8 @@ protected static RealmAwareZkClient createZkClient(HelixManager manager) {
     }
     RealmAwareZkClient.RealmAwareZkClientConfig clientConfig =
         new RealmAwareZkClient.RealmAwareZkClientConfig().setZkSerializer(new ZNRecordSerializer());
+    // Set operation retry timeout to prevent hanging infinitely
+    clientConfig.setOperationRetryTimeout(Duration.ofMinutes(5).toMillis());

Review comment:
       1. No hard code "5" please.
   2. Given this setup won't work as you mentioned in github.com/apache/helix/issues/1682, do we still need to add it here? It seems to be confusing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org