You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2026/08/21 20:11:53 UTC
[PR] test: Rewrite some parameterized classes to tests. (druid)
gianm opened a new pull request, #20108:
URL: https://github.com/apache/druid/pull/20108
With JUnit 5, ParameterizedClass leads to quadratic writes of Surefire reports, which causes significant overhead for certain of our highly-parameterized test suites. For more information see this Surefire issue: https://github.com/apache/maven-surefire/issues/3439.
This didn't happen on JUnit 4, so it's a test performance regression connected to the migration to JUnit 5.
This patch improves test runtime by ~8 minutes on my machine by switching four heavily-parameterized tests to use ParameterizedTest instead of ParameterizedTest. These four tests were originally migrated to JUnit 5 in #19980 and #19982.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] test: Rewrite some parameterized classes to tests. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #20108:
URL: https://github.com/apache/druid/pull/20108#issuecomment-5375919400
> Yes, I noticed this problem and fixed one in #19859. But during the following migration, I deliberately kept using ParameteriedClass so that the diff is small and easy to review because every batch we migrated lots of test cases.
> I intended to handle this problem in a follow up PR to improve test performance, and now you patched several tests. Thank you.
Ah, good to know. IMO, given how much things can slow down with `@ParameterizedClass`, it would be good to go directly to `@ParameterizedTest` in the migration of at least the highly-parameterized tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] test: Rewrite some parameterized classes to tests. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #20108:
URL: https://github.com/apache/druid/pull/20108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] test: Rewrite some parameterized classes to tests. (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #20108:
URL: https://github.com/apache/druid/pull/20108#issuecomment-5374834315
FYI @FrankChen021: this issue means we should avoid `@ParameterizedClass` in JUnit 5 for highly-parameterized classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] test: Rewrite some parameterized classes to tests. (druid)
Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 commented on PR #20108:
URL: https://github.com/apache/druid/pull/20108#issuecomment-5375782699
> FYI @FrankChen021: this issue means we should avoid `@ParameterizedClass` in JUnit 5 for highly-parameterized classes.
Yes, I noticed this problem and fixed one in #19859.
But during the following migration, I deliberately kept using ParameteriedClass so that the diff is small and easy to review because every batch we migrated lots of test cases.
I intended to handle this problem in a follow up PR to improve test performance, and now you patched several tests. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org