You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/04/14 05:56:26 UTC

[Impala-CR](cdh5-trunk) IMPALA-2995: Fix apparent time-travel in timestamp expr-test

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2787

Change subject: IMPALA-2995: Fix apparent time-travel in timestamp expr-test
......................................................................

IMPALA-2995: Fix apparent time-travel in timestamp expr-test

The expr test which tests unix_timestamp() after setting
FLAGS_use_local_tz_for_unix_timestamp_conversions used a different
method to get the 'before' and 'after' timestamps to
unix_timestamp(). As a result, the 'after' timestamp may rarely be
smaller than the value returned by unix_timestamp().

To fix this, I changed the expr-test logic to calculate the local
timestamps in the same way as unix_timestamp().

Change-Id: I9773949cdac051b8bea4a9fb61695c2bc0948bc3
---
M be/src/exprs/expr-test.cc
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/87/2787/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9773949cdac051b8bea4a9fb61695c2bc0948bc3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <he...@cloudera.com>