You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Massimo Paladin (JIRA)" <ji...@apache.org> on 2012/10/24 19:16:11 UTC

[jira] [Created] (AMQ-4133) Different behaviour with similar connectors with identical option, URI validation would be nice to have

Massimo Paladin created AMQ-4133:
------------------------------------

             Summary: Different behaviour with similar connectors with identical option, URI validation would be nice to have
                 Key: AMQ-4133
                 URL: https://issues.apache.org/jira/browse/AMQ-4133
             Project: ActiveMQ
          Issue Type: Bug
            Reporter: Massimo Paladin


Hello,

we noticed an inconsistent behaviour of stomp+ssl and stomp+nio+ssl with same connector options.

- stomp+ssl works with both {{transport.needClientAuth=true}} and {{needClientAuth=true}} options
- stomp+nio+ssl works with {{transport.needClientAuth=true}} but not with {{needClientAuth=true}}
In this last case it fails with a non-obvious exception:
{noformat}
junit.framework.ComparisonFailure: java.lang.SecurityException: Unable to authenticate transport without SSL certificate.
        at org.apache.activemq.security.JaasCertificateAuthenticationBroker.addConnection(JaasCertificateAuthenticationBroker.java:74)
        at org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:98)
{noformat}

It would be nice to have a URI parameters validation or the same behaviour with similar connectors.

What do you think?

Unit test which shows the problem attached, sorry for reusing pieces from another bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AMQ-4133) Different behaviour with similar connectors with identical option, URI validation would be nice to have

Posted by "Massimo Paladin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Massimo Paladin updated AMQ-4133:
---------------------------------

    Attachment: AMQ4133.tgz
    
> Different behaviour with similar connectors with identical option, URI validation would be nice to have
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4133
>                 URL: https://issues.apache.org/jira/browse/AMQ-4133
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Massimo Paladin
>         Attachments: AMQ4133.tgz
>
>
> Hello,
> we noticed an inconsistent behaviour of stomp+ssl and stomp+nio+ssl with same connector options.
> - stomp+ssl works with both {{transport.needClientAuth=true}} and {{needClientAuth=true}} options
> - stomp+nio+ssl works with {{transport.needClientAuth=true}} but not with {{needClientAuth=true}}
> In this last case it fails with a non-obvious exception:
> {noformat}
> junit.framework.ComparisonFailure: java.lang.SecurityException: Unable to authenticate transport without SSL certificate.
>         at org.apache.activemq.security.JaasCertificateAuthenticationBroker.addConnection(JaasCertificateAuthenticationBroker.java:74)
>         at org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:98)
> {noformat}
> It would be nice to have a URI parameters validation or the same behaviour with similar connectors.
> What do you think?
> Unit test which shows the problem attached, sorry for reusing pieces from another bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (AMQ-4133) Different behaviour with similar connectors with identical option, URI validation would be nice to have

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQ-4133.
-------------------------------

    Resolution: Fixed

Fixed on trunk.
                
> Different behaviour with similar connectors with identical option, URI validation would be nice to have
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4133
>                 URL: https://issues.apache.org/jira/browse/AMQ-4133
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 5.7.0
>            Reporter: Massimo Paladin
>            Priority: Minor
>             Fix For: 5.8.0
>
>         Attachments: AMQ4133.tgz
>
>
> Hello,
> we noticed an inconsistent behaviour of stomp+ssl and stomp+nio+ssl with same connector options.
> - stomp+ssl works with both {{transport.needClientAuth=true}} and {{needClientAuth=true}} options
> - stomp+nio+ssl works with {{transport.needClientAuth=true}} but not with {{needClientAuth=true}}
> In this last case it fails with a non-obvious exception:
> {noformat}
> junit.framework.ComparisonFailure: java.lang.SecurityException: Unable to authenticate transport without SSL certificate.
>         at org.apache.activemq.security.JaasCertificateAuthenticationBroker.addConnection(JaasCertificateAuthenticationBroker.java:74)
>         at org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:98)
> {noformat}
> It would be nice to have a URI parameters validation or the same behaviour with similar connectors.
> What do you think?
> Unit test which shows the problem attached, sorry for reusing pieces from another bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AMQ-4133) Different behaviour with similar connectors with identical option, URI validation would be nice to have

Posted by "Lionel Cons (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AMQ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483924#comment-13483924 ] 

Lionel Cons commented on AMQ-4133:
----------------------------------

ActiveMQ already performs strict XML validation to detect incorrect configuration items before starting the broker, this is very good.

It should IMHO also strictly validate the options given via the URI syntax and that therefore escape standard schema based validation.
                
> Different behaviour with similar connectors with identical option, URI validation would be nice to have
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4133
>                 URL: https://issues.apache.org/jira/browse/AMQ-4133
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Massimo Paladin
>         Attachments: AMQ4133.tgz
>
>
> Hello,
> we noticed an inconsistent behaviour of stomp+ssl and stomp+nio+ssl with same connector options.
> - stomp+ssl works with both {{transport.needClientAuth=true}} and {{needClientAuth=true}} options
> - stomp+nio+ssl works with {{transport.needClientAuth=true}} but not with {{needClientAuth=true}}
> In this last case it fails with a non-obvious exception:
> {noformat}
> junit.framework.ComparisonFailure: java.lang.SecurityException: Unable to authenticate transport without SSL certificate.
>         at org.apache.activemq.security.JaasCertificateAuthenticationBroker.addConnection(JaasCertificateAuthenticationBroker.java:74)
>         at org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:98)
> {noformat}
> It would be nice to have a URI parameters validation or the same behaviour with similar connectors.
> What do you think?
> Unit test which shows the problem attached, sorry for reusing pieces from another bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (AMQ-4133) Different behaviour with similar connectors with identical option, URI validation would be nice to have

Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AMQ-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish updated AMQ-4133:
------------------------------

          Component/s: Transport
             Priority: Minor  (was: Major)
    Affects Version/s: 5.7.0
        Fix Version/s: 5.8.0
    
> Different behaviour with similar connectors with identical option, URI validation would be nice to have
> -------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4133
>                 URL: https://issues.apache.org/jira/browse/AMQ-4133
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 5.7.0
>            Reporter: Massimo Paladin
>            Priority: Minor
>             Fix For: 5.8.0
>
>         Attachments: AMQ4133.tgz
>
>
> Hello,
> we noticed an inconsistent behaviour of stomp+ssl and stomp+nio+ssl with same connector options.
> - stomp+ssl works with both {{transport.needClientAuth=true}} and {{needClientAuth=true}} options
> - stomp+nio+ssl works with {{transport.needClientAuth=true}} but not with {{needClientAuth=true}}
> In this last case it fails with a non-obvious exception:
> {noformat}
> junit.framework.ComparisonFailure: java.lang.SecurityException: Unable to authenticate transport without SSL certificate.
>         at org.apache.activemq.security.JaasCertificateAuthenticationBroker.addConnection(JaasCertificateAuthenticationBroker.java:74)
>         at org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:98)
> {noformat}
> It would be nice to have a URI parameters validation or the same behaviour with similar connectors.
> What do you think?
> Unit test which shows the problem attached, sorry for reusing pieces from another bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira