[GitHub] leventov commented on issue #6893: Add several missing inspectRuntimeShape() calls

[GitBox <gi...@apache.org>]

leventov commented on issue #6893: Add several missing inspectRuntimeShape() calls
URL: https://github.com/apache/incubator-druid/pull/6893#issuecomment-458092103
 
 
   @AlexanderSaydakov the cost of not inspecting something that influences the runtime shape could be significant or not very significant, depending on how big and where in the call stack is that influence. In the worst case, it cancels the optimization framework for the given type of aggregator.
   
   There might also be some performance cost of inspecting something extra, but it is generally lower than the cost of not inspecting something important:
    - Creation of extra unneeded classes, storing their bytecode and native code in memory (hence extra icache pollution)
    - Separate runtime shapes (those that in fact shouldn't be separate) don't pass the optimization threshold individually, but if there was just one, it would pass the threshold. Bad, but if the runtime shape barely exceeds the optimization threshold not optimizing it is not a super big deal.
   
   None of the above affects the correctness of results whatsoever.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org