You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/05/30 18:00:40 UTC

[GitHub] [thrift] kainjow commented on a change in pull request #2127: THRIFT-5187: Added Win32 support for domain sockets (AF_UNIX)

kainjow commented on a change in pull request #2127:
URL: https://github.com/apache/thrift/pull/2127#discussion_r432874427



##########
File path: build/cmake/ConfigureChecks.cmake
##########
@@ -52,14 +55,24 @@ check_include_file(sched.h HAVE_SCHED_H)
 check_include_file(string.h HAVE_STRING_H)
 check_include_file(strings.h HAVE_STRINGS_H)
 
+check_cxx_source_compiles(
+  "
+  #define WIN32_LEAN_AND_MEAN
+  #include <windows.h>
+  #include <winsock2.h>
+  #include <afunix.h>
+  int main(){(void)sizeof(((struct sockaddr_un *)0)->sun_path); return 0;}
+  "
+  HAVE_AF_UNIX_H)
+#check_struct_has_member("struct sockaddr_un" sun_path "afunix.h" HAVE_AF_UNIX_H LANGUAGE CXX)

Review comment:
       Is this commented-out line needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org