You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by el...@apache.org on 2008/10/27 19:22:34 UTC
svn commit: r708268 -
/mina/trunk/core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
Author: elecharny
Date: Mon Oct 27 11:22:33 2008
New Revision: 708268
URL: http://svn.apache.org/viewvc?rev=708268&view=rev
Log:
Unfold some method chaining.
Modified:
mina/trunk/core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
Modified: mina/trunk/core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java
URL: http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java?rev=708268&r1=708267&r2=708268&view=diff
==============================================================================
--- mina/trunk/core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java (original)
+++ mina/trunk/core/src/main/java/org/apache/mina/core/polling/AbstractPollingIoProcessor.java Mon Oct 27 11:22:33 2008
@@ -33,6 +33,7 @@
import org.apache.mina.core.buffer.IoBuffer;
import org.apache.mina.core.file.FileRegion;
+import org.apache.mina.core.filterchain.IoFilterChain;
import org.apache.mina.core.future.DefaultIoFuture;
import org.apache.mina.core.service.AbstractIoService;
import org.apache.mina.core.service.IoProcessor;
@@ -427,7 +428,8 @@
// Clear the DefaultIoFilterChain.CONNECT_FUTURE attribute
// and call ConnectFuture.setException().
scheduleRemove(session);
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
wakeup();
} else {
ExceptionMonitor.getInstance().exceptionCaught(e);
@@ -482,7 +484,8 @@
destroy(session);
return true;
} catch (Exception e) {
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
} finally {
clearWriteRequestQueue(session);
((AbstractIoService) session.getService()).getListeners().fireSessionDestroyed(session);
@@ -507,7 +510,8 @@
buf.reset();
failedRequests.add(req);
} else {
- session.getFilterChain().fireMessageSent(req);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireMessageSent(req);
}
} else {
failedRequests.add(req);
@@ -526,7 +530,8 @@
session.decreaseScheduledBytesAndMessages(r);
r.getFuture().setException(cause);
}
- session.getFilterChain().fireExceptionCaught(cause);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(cause);
}
}
@@ -579,7 +584,8 @@
}
if (readBytes > 0) {
- session.getFilterChain().fireMessageReceived(buf);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireMessageReceived(buf);
buf = null;
if (hasFragmentation) {
@@ -597,7 +603,8 @@
if (e instanceof IOException) {
scheduleRemove(session);
}
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
}
}
@@ -629,7 +636,8 @@
}
} catch (Exception e) {
scheduleRemove(session);
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
}
break;
case CLOSED:
@@ -729,7 +737,8 @@
}
} while (writtenBytes < maxWrittenBytes);
} catch (Exception e) {
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
return false;
}
@@ -795,7 +804,8 @@
private void fireMessageSent(T session, WriteRequest req) {
session.setCurrentWriteRequest(null);
- session.getFilterChain().fireMessageSent(req);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireMessageSent(req);
}
private void updateTrafficMask() {
@@ -832,7 +842,8 @@
try {
setInterestedInRead(session, (mask & SelectionKey.OP_READ) != 0);
} catch (Exception e) {
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
}
try {
setInterestedInWrite(
@@ -840,7 +851,8 @@
!session.getWriteRequestQueue().isEmpty(session) &&
(mask & SelectionKey.OP_WRITE) != 0);
} catch (Exception e) {
- session.getFilterChain().fireExceptionCaught(e);
+ IoFilterChain filterChain = session.getFilterChain();
+ filterChain.fireExceptionCaught(e);
}
}