You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2026/05/16 01:02:01 UTC

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24315


Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

This patch makes Impala produce Ranger audit events for the GRANT/REVOKE
ROLE statements.

Testing:
 - Added Java test cases to verify the Ranger audit events are really
   produced in various scenarios.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 328 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22507/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 01:55:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Yida Wu, Abhishek Rawat, Jason Fehr, Csaba Ringhofer, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#10).

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Due to RANGER-5595, Impala could not produce Ranger audit events for
the GRANT/REVOKE ROLE statements. This patch works around this issue by
mimicking what RangerHiveAuthorizer#grantRole() does at
https://github.com/apache/ranger/blob/3fd46db/hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java#L609-L612.

On a related note, adding the test cases for the GRANT/REVOKE privilege
statements is not in the scope of this JIRA. IMPALA-15011 was created to
keep track of this.

Testing:
 - Added Java test cases to verify Ranger audit events could be produced
   for the GRANT/REVOKE ROLE statements.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 396 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/10
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22497/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2026 18:15:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#7).

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Due to RANGER-5595, Impala could not produce Ranger audit events for
the GRANT/REVOKE ROLE statements. This patch works around this issue by
mimicking what RangerHiveAuthorizer#grantRole() does at
https://github.com/apache/ranger/blob/3fd46db/hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java#L609-L612.

On a related note, adding the test cases for the GRANT/REVOKE privilege
statements is not in the scope of this JIRA. IMPALA-15011 was created to
keep track of this.

Testing:
 - Added Java test cases to verify Ranger audit events could be produced
   for the GRANT/REVOKE ROLE statements.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerBufferAuditHandler.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
9 files changed, 399 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/7
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10:

(3 comments)

I addressed Michael's comments on patch set 9. Let me know if there are additional suggestions. Thanks!

http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@182
PS9, Line 182:     User requestingUser = new User(header.getRequesting_user());
> Do we need to verify getRequesting_user is set? Previously we had that as a
Yes, you are correct. I will add a Preconditions.checkNotNull(requestingUser) here in the next patch.


http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@205
PS9, Line 205:       plugin_.get().revokeRole(request, /*resultProcessor*/ null);
> typo: because
Done


http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@667
PS9, Line 667: 
> This is a typo. I will correct it in the next patch.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 19:23:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13515/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2026 01:34:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24315/8/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/8/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@257
PS8, Line 257: assertEquals(policyId, event.getPolicyId());
The tests may be easier to maintain if we do not check the exact policy id. For instance, the policy id of a given policy, e.g., "all - database", could be different for a different version of Ranger server.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 May 2026 23:26:35 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13503/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 May 2026 01:02:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#4).

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

This patch makes Impala produce Ranger audit events for the GRANT/REVOKE
ROLE statements.

This also excludes xmlsectool to see if the Java code could be compiled.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 345 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13507/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 May 2026 17:06:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2026 21:47:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22554/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 7
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 May 2026 19:47:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13734/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 19:22:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 20:04:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@139
PS10, Line 139:   public void testRevokeRoleAuditEvents() throws Exception {
> This unit test relies on the testGrantRoleAuditEvents having been run first
Thanks for pointing this out Jason!

I ran the following alone and found that testRevokeRoleAuditEvents() could run without testGrantRoleAuditEvents having been run first.

 (pushd fe && mvn test -Dtest=RangerCatalogdAuthorizationManagerTest#testRevokeRoleAuditEvents)

I think the reason is that as long as the role TEST_ROLE exists, even though this role is not granted to REVOKEE_USER or REVOKEE_GROUP, Ranger server would not complain after receiving such a request (e.g., "REVOKE ROLE test_role FROM USER non_owner") from Impala's Ranger plug-in.

On the other hand, we do have to make sure TEST_ROLE exists before running this test method. We guarantee this by setUpTest() at https://gerrit.cloudera.org/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java#76.

Let me know if I missed something. Thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 22:57:51 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22459/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 May 2026 01:23:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#3).

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

This patch makes Impala produce Ranger audit events for the GRANT/REVOKE
ROLE statements.

This also excludes xmlsectool to see if the Java code could be compiled.

Testing:
 - Added Java test cases to verify the Ranger audit events are really
   produced in various scenarios.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/pom.xml
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
8 files changed, 349 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#2).

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

This patch makes Impala produce Ranger audit events for the GRANT/REVOKE
ROLE statements.

Testing:
 - Added Java test cases to verify the Ranger audit events are really
   produced in various scenarios.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 345 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 8:

Added some more reviewers to see if anyone is available to review the patch. Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 16:07:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 23:44:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 5:
> 
> (1 comment)

I corrected a typo in patch set 5.

http://gerrit.cloudera.org:8080/#/c/24315/5/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/5/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@79
PS5, Line 79: 'staticPluginRef'
> typo: staticPluginRef
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 01:41:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 6:
> 
> Build Failed 
> 
> https://jenkins.impala.io/job/gerrit-code-review-checks/22509/ : Initial code review checks failed. See linked job for details on the failure.

Failed due to the following error.

 18:50:03 01:50:02 [INFO] Apache Impala Query Engine Frontend 5.0.0-SNAPSHOT . FAILURE [  8.609 s]
 18:50:03 01:50:02 [INFO] BUILD FAILURE
 18:50:03 01:50:02 [ERROR] Failed to execute goal on project impala-frontend: Could not collect dependencies for project org.apache.impala:impala-frontend:jar:5.0.0-SNAPSHOT
 18:50:03 01:50:02 [ERROR] Failed to read artifact descriptor for net.shibboleth.tool:xmlsectool:jar:2.0.0
 18:50:03 01:50:02 [ERROR] 	Caused by: The following artifacts could not be resolved: net.shibboleth.tool:xmlsectool:pom:2.0.0 (absent): Could not transfer artifact net.shibboleth.tool:xmlsectool:pom:2.0.0 from/to impala.cdp.repo (https://native-toolchain-us-west-2.s3.us-west-2.amazonaws.com/build/cdp_components/73534044/maven): status code: 403, reason phrase: Forbidden (403)

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@248
PS6, Line 248:       auditGrantRevokeRole(header, GRANT_ROLE_ACTION, isAllowed, requestingUser);
It may be a good idea to log the time spent on this operation like what we do at https://github.com/apache/impala/blob/18ed94d/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java#L343-L344.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 16:39:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13507/


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 May 2026 21:20:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22477/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 17 May 2026 17:27:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 8:

(3 comments)

Addressed some of my own comments on patch set 6.

Let me know if there are additional suggestions. Thanks very much for the help!

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@124
PS6, Line 124:    /* result
> If we instantiate a GrantRevokeRoleStmt, then we could call its toSql() to 
This is addressed in the patch set 8.


http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@161
PS6, Line 161:       assertEventEquals(events.get(0), ALTER_ACTION, ALTER_ACCESS_TYPE
> If we instantiate a GrantRevokeRoleStmt, then we could call its toSql() to 
This is addressed in the patch set 8.


http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@201
PS6, Line 201:       resultChecker.accept(capturedAuditHandlers);
             :     } finally {
             :       TCatalogServiceRequestHeader adminHeader = createHeader(RANGER_ADMIN.getName(),
             :           "revoke role " + role + " from " + granteeUser, CLIENT_IP_ADDRESS);
             :       authzManager.revokeRoleFromGroupOrUser(adminHeader, params,
             :           new TDdlExecResponse(new TCatalogUpdateResult()));
             :       capturedAuditHandlers.clear();
             :     }
             :   }
             : 
             :   private void revokeRole(Consumer<List<AutoFlush>> resultChecker, String revokerUser,
             :       String role, String revokeeGroup, String revokeeUser, boolean expectSuccess)
             :       throws Exception {
             :    
> We may be able to re-use the code at https://github.com/apache/impala/blob/
This is addressed in the patch set 8.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 May 2026 19:35:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 21 May 2026 00:05:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Due to RANGER-5595, Impala could not produce Ranger audit events for
the GRANT/REVOKE ROLE statements. This patch works around this issue by
mimicking what RangerHiveAuthorizer#grantRole() does at
https://github.com/apache/ranger/blob/3fd46db/hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java#L609-L612.

On a related note, adding the test cases for the GRANT/REVOKE privilege
statements is not in the scope of this JIRA. IMPALA-15011 was created to
keep track of this.

Testing:
 - Added Java test cases to verify Ranger audit events could be produced
   for the GRANT/REVOKE ROLE statements.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Reviewed-on: http://gerrit.cloudera.org:8080/24315
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 396 insertions(+), 22 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Impala Public Jenkins: Verified
  Jason Fehr: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 11
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13725/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 19:27:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23214/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 19:41:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 23:56:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#5).

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Due to RANGER-5595, Impala could not produce Ranger audit events for
the GRANT/REVOKE ROLE statements. This patch works around this issue by
mimicking what RangerHiveAuthorizer#grantRole() does at
https://github.com/apache/ranger/blob/3fd46db/hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java#L609-L612.

On a related note, adding the test cases for the GRANT/REVOKE privilege
statements is not in the scope of this JIRA. IMPALA-15011 was created to
keep track of this.

Testing:
 - Added Java test cases to verify Ranger audit events could be produced
   for the GRANT/REVOKE ROLE statements.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 358 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/5
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 5:

Hi all, please let me know if there is any comment on the patch. Thanks very much for the review!


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 01:35:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13524/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 May 2026 19:35:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24315/5/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/5/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@79
PS5, Line 79: staticPluginRef()
typo: staticPluginRef



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 01:39:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22493/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2026 17:38:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#6).

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Due to RANGER-5595, Impala could not produce Ranger audit events for
the GRANT/REVOKE ROLE statements. This patch works around this issue by
mimicking what RangerHiveAuthorizer#grantRole() does at
https://github.com/apache/ranger/blob/3fd46db/hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java#L609-L612.

On a related note, adding the test cases for the GRANT/REVOKE privilege
statements is not in the scope of this JIRA. IMPALA-15011 was created to
keep track of this.

Testing:
 - Added Java test cases to verify Ranger audit events could be produced
   for the GRANT/REVOKE ROLE statements.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 358 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/6
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Abhishek Rawat, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24315

to look at the new patch set (#8).

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................

IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Due to RANGER-5595, Impala could not produce Ranger audit events for
the GRANT/REVOKE ROLE statements. This patch works around this issue by
mimicking what RangerHiveAuthorizer#grantRole() does at
https://github.com/apache/ranger/blob/3fd46db/hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java#L609-L612.

On a related note, adding the test cases for the GRANT/REVOKE privilege
statements is not in the scope of this JIRA. IMPALA-15011 was created to
keep track of this.

Testing:
 - Added Java test cases to verify Ranger audit events could be produced
   for the GRANT/REVOKE ROLE statements.

Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
---
M fe/src/main/java/org/apache/impala/authorization/AuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/NoopAuthorizationFactory.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpalaResourceBuilder.java
M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
A fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
7 files changed, 394 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24315/8
-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22555/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 8
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 May 2026 19:56:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@667
PS9, Line 667: filed
This is a typo. I will correct it in the next patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 01:21:09 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@139
PS10, Line 139:   public void testRevokeRoleAuditEvents() throws Exception {
> Thanks for pointing this out Jason!
Interesting, that makes sense though since Ranger is only reporting the audit event, not actually modifying roles.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 23:56:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 6:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22509/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 02:03:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13510/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 May 2026 17:16:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 6:

(3 comments)

Left some comments. Will try to address them.

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@124
PS6, Line 124: grantSqlStmt
If we instantiate a GrantRevokeRoleStmt, then we could call its toSql() to produce the SQL statement.


http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@161
PS6, Line 161: String revokeSqlStmt = "revoke role " + role + " from " + revokeeUser;
If we instantiate a GrantRevokeRoleStmt, then we could call its toSql() to produce the SQL statement.


http://gerrit.cloudera.org:8080/#/c/24315/6/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@201
PS6, Line 201:   private static TGrantRevokeRoleParams createGrantRevokeRoleParams(String group,
             :       String user, String role) {
             :     TGrantRevokeRoleParams params = new TGrantRevokeRoleParams();
             :     if (group != null) {
             :       params.setGroup_names(Arrays.asList(group));
             :       params.setUser_names(new ArrayList<>());
             :     } else {
             :       Preconditions.checkArgument(user != null);
             :       params.setGroup_names(new ArrayList<>());
             :       params.setUser_names(Arrays.asList(user));
             :     }
             :     params.setRole_names(Arrays.asList(role));
             :     return params;
             :   }
We may be able to re-use the code at https://github.com/apache/impala/blob/18ed94d/fe/src/main/java/org/apache/impala/analysis/GrantRevokeRoleStmt.java#L58-L70 that achieves the same thing, if we could instantiate an instance of GrantRevokeRoleStmt.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 6
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 23:12:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: [WIP] Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13503/


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 May 2026 05:29:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13515/


-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 19 May 2026 05:57:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java
File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java:

http://gerrit.cloudera.org:8080/#/c/24315/10/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@139
PS10, Line 139:   public void testRevokeRoleAuditEvents() throws Exception {
This unit test relies on the testGrantRoleAuditEvents having been run first.  Generally, that is not a great idea since execution order is not guaranteed thus unit tests should be self-contained.  Please either make each unit test self contained or else modify the unit tests so one tests the full grant/revoke lifecycle for a group and the other tests the lifecycle for a user.



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 20:17:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24315 )

Change subject: IMPALA-14956: Produce Ranger audit events for GRANT/REVOKE ROLE
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java
File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java:

http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@182
PS9, Line 182:     User requestingUser = new User(header.getRequesting_user());
Do we need to verify getRequesting_user is set? Previously we had that as a precondition in the caller.


http://gerrit.cloudera.org:8080/#/c/24315/9/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@205
PS9, Line 205:       // Becuase of the issue reported in RANGER-5595, we could not provide
typo: because



-- 
To view, visit http://gerrit.cloudera.org:8080/24315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e0527af0532749817ea538c253262a5e2a65c61
Gerrit-Change-Number: 24315
Gerrit-PatchSet: 9
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 17:38:04 +0000
Gerrit-HasComments: Yes