You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/24 21:06:37 UTC
[GitHub] [pulsar] michaeljmarshall opened a new issue, #16214: Optimize AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
michaeljmarshall opened a new issue, #16214:
URL: https://github.com/apache/pulsar/issues/16214
**Is your enhancement request related to a problem? Please describe.**
In reading through the `AbstractTopic` code, I noticed that there are some inefficient stat generations. Specifically:
https://github.com/apache/pulsar/blob/b23689930e3af65cfc913e2890164a071acda440/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java#L1135-L1141
**Describe the solution you'd like**
Based on quickly reading through the usages of these methods and the definition of `getStats`, I think we should find a more direct way to compute the values for these counters.
**Additional context**
I am happy to help review any PRs for this enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on issue #16214: Optimize AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
Posted by GitBox <gi...@apache.org>.
nahguam commented on issue #16214:
URL: https://github.com/apache/pulsar/issues/16214#issuecomment-1169618371
I can look at this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #16214: Optimize AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #16214:
URL: https://github.com/apache/pulsar/issues/16214#issuecomment-1173305428
@nahguam - thanks for contributing the fix for this issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie closed issue #16214: Optimize AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
Posted by GitBox <gi...@apache.org>.
RobertIndie closed issue #16214: Optimize AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
URL: https://github.com/apache/pulsar/issues/16214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org