[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #12: Fix wrong index rule binding for Measure

[GitBox <gi...@apache.org>]

lujiajing1126 commented on code in PR #12:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/12#discussion_r863497532


##########
src/main/java/org/apache/skywalking/banyandb/v1/client/TagAndValue.java:
##########
@@ -104,6 +104,26 @@ public static TagAndValue<String> newStringTag(final String tagName, final Strin
         return new StringTagPair(tagName, value);
     }
 
+    @EqualsAndHashCode(callSuper = true)
+    public static class IDTagPair extends TagAndValue<String> {

Review Comment:
   Emmmm, I've checked the code again. You're right. According to the implementation, it has to be named as `id` which is required by the hardcoded name here https://github.com/apache/skywalking-banyandb/blob/49a23ae9bdcc65ae7028617a3bf86bb243ffec64/banyand/metadata/schema/measure.go#L172
   
   But we actually don't have any kind of mandatory validation for this name elsewhere. On the client-side, I should have hidden the low-level impl here.
   
   As I understood, 
   
   1. `ID` is the default sharding key if no other sharding key is specified (e.g. `entity_id`),
   2. `ID` is indexed automatically which allows us to search by ID directly,
   
   @hanahmily any other comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org