You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/02/23 20:18:40 UTC
Review Request 70045: Skipped tests when verifying `master` as part of
review verification.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/
-----------------------------------------------------------
Review request for mesos, Till Toenshoff and Vinod Kone.
Repository: mesos
Description
-------
Due to flakes test results reported by reviewbot need manual
verification so we can skip executing tests when validating the
`master` branch. This saves some execution time during validation.
Incidentally with this patch a previous comment matches now matches
what is happening.
Diffs
-----
support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
Diff: https://reviews.apache.org/r/70045/diff/1/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213121
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70045]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 8:18 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
>
> Incidentally with this patch a previous comment matches now matches
> what is happening.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
>
>
> Diff: https://reviews.apache.org/r/70045/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213127
-----------------------------------------------------------
PASS: Mesos patch 70045 was successfully built and tested.
Reviews applied: `['70045']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2927/mesos-review-70045
- Mesos Reviewbot Windows
On Feb. 24, 2019, 2:03 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2019, 2:03 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
>
> Incidentally with this patch a previous comment matches now matches
> what is happening.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
>
>
> Diff: https://reviews.apache.org/r/70045/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213126
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Feb. 24, 2019, 10:03 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2019, 10:03 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
>
> Incidentally with this patch a previous comment matches now matches
> what is happening.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
>
>
> Diff: https://reviews.apache.org/r/70045/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/
-----------------------------------------------------------
(Updated Feb. 24, 2019, 11:03 p.m.)
Review request for mesos, Till Toenshoff and Vinod Kone.
Repository: mesos
Description
-------
Due to flakes test results reported by reviewbot need manual
verification so we can skip executing tests when validating the
`master` branch. This saves some execution time during validation.
Incidentally with this patch a previous comment matches now matches
what is happening.
Diffs (updated)
-----
support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
Diff: https://reviews.apache.org/r/70045/diff/2/
Changes: https://reviews.apache.org/r/70045/diff/1-2/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213120
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70045']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2925/mesos-review-70045
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2925/mesos-review-70045/logs/mesos-tests.log):
```
I0223 21:27:02.819763 15548 ex is terminating
I0223 21:27:02.820765 65472 master.cpp:1269] Agent 4a6c8b55-95e3-4a7a-b0d1-21364aa645c0-S0 at slave(494)@192.10.1.6:52785 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0223 21:27:02.820765 65472 master.cpp:3292] Disconnecting agent 4a6c8b55-95e3-4a7a-b0d1-21364aa645c0-S0 at slave(494)@192.10.1.6:52785 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0223 21:27:02.820765 65472 master.cpp:3311] Deactivating agent 4a6c8b55-95e3-4a7a-b0d1-21364aa645c0-S0 at slave(494)@192.10.1.6:52785 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0223 21:27:02.820765 63040 hierarchical.cpp:390] Removed framework 4a6c8b55-95e3-4a7a-b0d1-21364aa645c0-0000
I0223 21:27:02.820765 63040 hierarchical.cpp:827] Agent 4a6c8b55-95e3-4a7a-b0d1-21364aa645c0-S0 deactivated
I0223 21:27:02.822764 63040 containerizer.cpp:2526] Destroying container d5abeaa5-a9d6-484d-ba8f-5e1d78bf7d62 in RUNNING state
I0223 21:27:02.823782 63040 containerizer.cpp:3193] Transition[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (689 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (708 ms total)
[----------] Global test environment tear-down
[==========] 1115 tests from 106 test cases ran. (566668 ms total)
[ PASSED ] 1114 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 232 DISABLED TESTS
ing the state of container d5abeaa5-a9d6-484d-ba8f-5e1d78bf7d62 from RUNNING to DESTROYING
I0223 21:27:02.823782 63040 launcher.cpp:161] Asked to destroy container d5abeaa5-a9d6-484d-ba8f-5e1d78bf7d62
W0223 21:27:02.824772 64660 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=2600 to peer '192.10.1.6:55181': IO failed with error code: The specified network name is no longer available.
W0223 21:27:02.825767 64660 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=2916 to peer '192.10.1.6:55182': IO failed with error code: The specified network name is no longer available.
I0223 21:27:02.890841 69728 containerizer.cpp:3032] Container d5abeaa5-a9d6-484d-ba8f-5e1d78bf7d62 has exited
I0223 21:27:02.920841 69728 master.cpp:1109] Master terminating
I0223 21:27:02.921860 60944 hierarchical.cpp:678] Removed agent 4a6c8b55-95e3-4a7a-b0d1-21364aa645c0-S0
I0223 21:27:03.782843 64660 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Feb. 23, 2019, 12:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 12:18 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
>
> Incidentally with this patch a previous comment matches now matches
> what is happening.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
>
>
> Diff: https://reviews.apache.org/r/70045/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 23, 2019, 11:55 p.m., Vinod Kone wrote:
> > support/jenkins/reviewbot.sh
> > Lines 38 (patched)
> > <https://reviews.apache.org/r/70045/diff/1/?file=2126559#file2126559line38>
> >
> > I don't think this is needed because verify-reviews.py sets the ENVIRONMENT and other variables explicitly before verifying the review.
> >
> > The comment at #33 should probably moved to #27.
Done. Added a comment on verification setting up its own env to document our assumptions.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213122
-----------------------------------------------------------
On Feb. 23, 2019, 9:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 9:18 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
>
> Incidentally with this patch a previous comment matches now matches
> what is happening.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
>
>
> Diff: https://reviews.apache.org/r/70045/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70045: Skipped tests when verifying `master` as
part of review verification.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70045/#review213122
-----------------------------------------------------------
Fix it, then Ship it!
support/jenkins/reviewbot.sh
Line 31 (original), 31 (patched)
<https://reviews.apache.org/r/70045/#comment298974>
Add a comment here that we are not running tests for when building HEAD?
support/jenkins/reviewbot.sh
Lines 38 (patched)
<https://reviews.apache.org/r/70045/#comment298973>
I don't think this is needed because verify-reviews.py sets the ENVIRONMENT and other variables explicitly before verifying the review.
The comment at #33 should probably moved to #27.
- Vinod Kone
On Feb. 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70045/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2019, 8:18 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to flakes test results reported by reviewbot need manual
> verification so we can skip executing tests when validating the
> `master` branch. This saves some execution time during validation.
>
> Incidentally with this patch a previous comment matches now matches
> what is happening.
>
>
> Diffs
> -----
>
> support/jenkins/reviewbot.sh 3cdd7f1c909c930a561ce2890212118579a47b73
>
>
> Diff: https://reviews.apache.org/r/70045/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>