You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/12 19:15:29 UTC

[GitHub] [solr] dsmiley commented on pull request #1004: SOLR-16404: Use newer clients in the Prometheus Exporter

dsmiley commented on PR #1004:
URL: https://github.com/apache/solr/pull/1004#issuecomment-1244201570

   Your changes explicitly refer to `BaseHttpSolrClient` but that's kind of sad to me; I view this class as an implementation detail to a subclass.  Can you undo that?  As I look at BaseHttpSolrClient; I think it should cease to exist.  Its contents are static inner classes that appear suitable in SolrClient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org