You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2004/09/23 18:33:05 UTC

Re: svn commit: r11090 - trunk/subversion/libsvn_ra_dav

On Wed, 22 Sep 2004 kfogel@tigris.org wrote:

> Author: kfogel
> Date: Wed Sep 22 16:11:30 2004
> New Revision: 11090
>
> Modified:
>    trunk/subversion/libsvn_ra_dav/fetch.c
> Log:
> Fix bug whereby update target paths were not XML-escaped.  Thanks to
> Roland Ruedenauer <Ro...@yellow-computing.de>, who said
> in http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=77935
> that if the target filename contained (say) an ampersand, invalid XML
> would go over the wire.
>
> * subversion/libsvn_ra_dav/fetch.c
>   (svn_xml_escape_cdata_cstring): XML-escape the target.
Well, you actually changed the make_reporter function...

Regards,

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r11090 - trunk/subversion/libsvn_ra_dav

Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Fri, 1 Oct 2004, Julian Foad wrote:

> Peter N. Lundblad wrote:
> > On Wed, 22 Sep 2004 kfogel@tigris.org wrote:
> >
> >>Author: kfogel
> >>Date: Wed Sep 22 16:11:30 2004
> >>New Revision: 11090
> >>
> >>Modified:
> >>   trunk/subversion/libsvn_ra_dav/fetch.c
> >>Log:
> >>Fix bug whereby update target paths were not XML-escaped.  Thanks to
> >>Roland Ruedenauer <Ro...@yellow-computing.de>, who said
> >>in http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=77935
> >>that if the target filename contained (say) an ampersand, invalid XML
> >>would go over the wire.
> >>
> >>* subversion/libsvn_ra_dav/fetch.c
> >>  (svn_xml_escape_cdata_cstring): XML-escape the target.
> >
> > Well, you actually changed the make_reporter function...
>
> Karl, a reminder: Peter is pointing out an error in your log message.
>
Hehe, just took the chance to give back:-)

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r11090 - trunk/subversion/libsvn_ra_dav

Posted by kf...@collab.net.
Julian Foad <ju...@btopenworld.com> writes:
> >>* subversion/libsvn_ra_dav/fetch.c
> >>  (svn_xml_escape_cdata_cstring): XML-escape the target.
> > Well, you actually changed the make_reporter function...
> 
> Karl, a reminder: Peter is pointing out an error in your log message.

Thanks, Julian and Peter.  I've fixed the log message now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r11090 - trunk/subversion/libsvn_ra_dav

Posted by Julian Foad <ju...@btopenworld.com>.
Peter N. Lundblad wrote:
> On Wed, 22 Sep 2004 kfogel@tigris.org wrote:
> 
>>Author: kfogel
>>Date: Wed Sep 22 16:11:30 2004
>>New Revision: 11090
>>
>>Modified:
>>   trunk/subversion/libsvn_ra_dav/fetch.c
>>Log:
>>Fix bug whereby update target paths were not XML-escaped.  Thanks to
>>Roland Ruedenauer <Ro...@yellow-computing.de>, who said
>>in http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=77935
>>that if the target filename contained (say) an ampersand, invalid XML
>>would go over the wire.
>>
>>* subversion/libsvn_ra_dav/fetch.c
>>  (svn_xml_escape_cdata_cstring): XML-escape the target.
> 
> Well, you actually changed the make_reporter function...

Karl, a reminder: Peter is pointing out an error in your log message.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org