You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "stankiewicz (via GitHub)" <gi...@apache.org> on 2026/04/21 10:09:34 UTC

[PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

stankiewicz opened a new pull request, #38256:
URL: https://github.com/apache/beam/pull/38256

   
   ## Description
   This PR resolves violations for several ErrorProne checks that were previously disabled in `BeamModulePlugin.groovy`.
   
   ## Changes by ErrorProne Check
   
   ### AutoValueSubclassLeaked
   - **`sdks/java/io/google-cloud-platform`**:
       - `BigQueryIO.java`: Added static `builder()` methods to `TypedRead` and `Write` classes to avoid direct referencing of generated AutoValue builders.
       - `BigQueryIOTranslation.java`: Updated to use new static builder methods.
       - `BigQueryCoderProviderRegistrar.java`: Replaced direct reference to `AutoValue_RowMutation.class` with `RowMutation.class`.
       - `WritePartition.java`: Added public static factory method `of(...)` to `Result` class.
       - `WriteTables.java`: Added public static factory method `of(...)` to `Result` class.
       - `BigQueryIOWriteTest.java`: Updated to use new factory methods.
   - **`runners/java-fn-execution`**:
       - `DefaultJobBundleFactory.java`: Added `builder()` method to `ServerInfo` to avoid direct reference to `AutoValue_DefaultJobBundleFactory_ServerInfo.Builder`.
       - `DefaultJobBundleFactoryTest.java`: Updated to use the new builder.
   - **`sdks/java/io/mongodb`**:
       - `MongoDbIO.java`: Replaced `getClass() == AutoValue_FindQuery.class` with `instanceof FindQuery` to avoid direct references to generated classes.
   - **`sdks/java/core`**:
       - `GenerateSequenceTest.java`: Replaced direct instantiation of `AutoValue_GenerateSequence` with factory methods.
   
   ### EscapedEntity
   - **`sdks/java/io/hadoop-format`**:
       - `HadoopFormatIO.java`: Fixed HTML entities like `&lt;` and `&quot;` inside Javadoc `{@code ...}` blocks.
   - **`sdks/java/core`**:
       - `ApproximateQuantiles.java`: Fixed HTML entities like `&lt;` inside Javadoc `{@code ...}` blocks.
   
   ### JUnitIncompatibleType
   - **`sdks/java/core`**:
       - `LogicalTypesTest.java`: Fixed incompatible types in `assertEquals` by using the correct expected class type.
   
   ### EqualsUnsafeCast
   - **`sdks/java/core`**:
       - `TestPOJOs.java`: Fixed wrong class in `instanceof` check in `equals` method (checked `PojoWithNestedArray` but cast to `PojoWithIterable`).
   
   ### Build Configuration
   - **`buildSrc`**:
       - `BeamModulePlugin.groovy`: Enabled `AutoValueSubclassLeaked`, `EqualsUnsafeCast`, `EscapedEntity`, `NonCanonicalType`, `UnescapedEntity`, and `JUnitIncompatibleType` by removing them from `disabledChecks`.
   
   ## Verification
   - Verified that compilation passes for the affected modules.
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38256:
URL: https://github.com/apache/beam/pull/38256#issuecomment-4303699230

   Assigning reviewers:
   
   R: @Abacn for label java.
   R: @liferoad for label build.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38256:
URL: https://github.com/apache/beam/pull/38256#issuecomment-4287684966

   ## Summary of Changes
   
   Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request enables a suite of ErrorProne checks that were previously disabled in the project's build configuration. To support this, the codebase has been refactored to eliminate direct dependencies on generated AutoValue classes, improve Javadoc documentation by fixing escaped entities, and resolve type-related issues in tests. These changes improve code quality and maintainability by enforcing stricter static analysis rules.
   
   ### Highlights
   
   * **ErrorProne Configuration**: Enabled several previously disabled ErrorProne checks in BeamModulePlugin.groovy, including AutoValueSubclassLeaked, EqualsUnsafeCast, EscapedEntity, and JUnitIncompatibleType.
   * **AutoValue Refactoring**: Updated various components to avoid direct references to generated AutoValue classes by introducing static builder or factory methods.
   * **Javadoc and Type Fixes**: Corrected HTML entities in Javadoc blocks and resolved type inconsistencies in unit tests to satisfy the newly enabled checks.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   </details>
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38256:
URL: https://github.com/apache/beam/pull/38256#issuecomment-4289345918

   /gemini review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38256:
URL: https://github.com/apache/beam/pull/38256#issuecomment-4298712843

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "stankiewicz (via GitHub)" <gi...@apache.org>.
stankiewicz commented on PR #38256:
URL: https://github.com/apache/beam/pull/38256#issuecomment-4298401530

   flaky flink, same happening on master -https://github.com/apache/beam/actions/runs/24769744791/job/72472821150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38256:
URL: https://github.com/apache/beam/pull/38256#discussion_r3118206462


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java:
##########
@@ -507,8 +507,8 @@ private long offset(long newWeight) {
 
     /**
      * Emulates taking the ordered union of all elements in buffers, repeated according to their
-     * weight, and picking out the (k * step + offset)-th elements of this list for {@code 0 &lt;= k
-     * &lt; count}.
+     * weight, and picking out the (k * step + offset)-th elements of this list for 0 &lt;= k &lt;
+     * count.

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   While removing `{@code}` resolves the `EscapedEntity` check, it's generally better to keep the code formatting for mathematical expressions in Javadoc. You can use the literal characters inside the `{@code}` block instead of HTML entities.
   
   ```suggestion
        * weight, and picking out the (k * step + offset)-th elements of this list for {@code 0 <= k <
        * count}.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ErrorProne] enable AutoValueSubclassLeaked, EscapedEntity, JUnitIncompatibleType, EqualsUnsafeCast [beam]

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #38256:
URL: https://github.com/apache/beam/pull/38256


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org