You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by kazimazar <no...@github.com> on 2018/11/29 02:49:13 UTC
[jclouds/jclouds] JCLOUDS-1467 (#1260)
Added support for c5d & m5d AWS nodes. Enhancement done using JCLOUDS-1387 & JCLOUDS-1436 were missing AWS series c5d & m5d for NVMe Instance Storage, this ticket is adding that missing AWS nodes support to jclouds.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1260
-- Commit Summary --
* JCLOUDS-1467
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java (161)
M apis/ec2/src/main/java/org/jclouds/ec2/domain/InstanceType.java (139)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/AWSEC2HardwareSupplier.java (24)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1260.patch
https://github.com/jclouds/jclouds/pull/1260.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260
Re: [jclouds/jclouds] JCLOUDS-1467 (#1260)
Posted by Daniel Estévez <no...@github.com>.
Thanks again @kazimazar!
Merged to [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8dcfd862) and [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/5916059b)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#issuecomment-443893924
Re: [jclouds/jclouds] JCLOUDS-1467 (#1260)
Posted by kazimazar <no...@github.com>.
@kazimazar pushed 1 commit.
1e2cc2d JCLOUDS-1467
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1260/files/12ccb3d0aa5dd60f39dc52688e4b593fb80dc69a..1e2cc2df32a6f556bd66009b06102dc83f29d3dc
Re: [jclouds/jclouds] JCLOUDS-1467 (#1260)
Posted by kazimazar <no...@github.com>.
Hi Daniel,
I have updated the SSD configs, please proceed further & let me know if there is anything else.
Thanks,
Kazim
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#issuecomment-443757328
Re: [jclouds/jclouds] JCLOUDS-1467 (#1260)
Posted by Daniel Estévez <no...@github.com>.
danielestevez approved this pull request.
Thanks @kazimazar
I noticed a small difference between here https://aws.amazon.com/blogs/aws/ec2-instance-update-c5-instances-with-local-nvme-storage-c5d/ and some sizes for the c5d instances
Could you please check this info and fix it if needed?
I'll commit it as soon as possible.
> + .volumes(ImmutableList.<Volume>of(
+ new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+ new VolumeBuilder().type(LOCAL).size(200.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))
+ .is64Bit(true);
+ }
+
+ /**
+ * @see InstanceType#C5D_4XLARGE
+ */
+ public static EC2HardwareBuilder c5d_4xlarge() {
+ return new EC2HardwareBuilder(InstanceType.C5D_4XLARGE).c5()
+ .ram(32768)
+ .processors(ImmutableList.of(new Processor(16.0, 3.0)))
+ .volumes(ImmutableList.<Volume>of(
+ new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+ new VolumeBuilder().type(LOCAL).size(400.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))
should be 450.0f
> + .volumes(ImmutableList.<Volume>of(
+ new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+ new VolumeBuilder().type(LOCAL).size(100.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))
+ .is64Bit(true);
+ }
+
+ /**
+ * @see InstanceType#C5D_2XLARGE
+ */
+ public static EC2HardwareBuilder c5d_2xlarge() {
+ return new EC2HardwareBuilder(InstanceType.C5D_2XLARGE).c5()
+ .ram(16384)
+ .processors(ImmutableList.of(new Processor(8.0, 3.0)))
+ .volumes(ImmutableList.<Volume>of(
+ new VolumeBuilder().type(LOCAL).size(10.0f).device("/dev/sda1").bootDevice(true).durable(false).build(),
+ new VolumeBuilder().type(LOCAL).size(200.0f).device("/dev/sdb").bootDevice(false).durable(false).build()))
should be 225.0f
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#pullrequestreview-180574353
Re: [jclouds/jclouds] JCLOUDS-1467 (#1260)
Posted by Daniel Estévez <no...@github.com>.
Closed #1260.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#event-2002768423