[jira] [Commented] (PHOENIX-2137) Range query on DECIMAL DESC sometimes incorrect

["Samarth Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653923#comment-14653923 ] 

Samarth Jain commented on PHOENIX-2137:
---------------------------------------

Patch looks good [~jamestaylor]. There are a few additional test cases that could be added (unless you know of existing tests that do the below already) :
1) Test with SALT_BUCKETS and DESC in row key.
2) Test with DESC and fixed width row key and DESC and variable length row key to exercise the byte comparator logic.
3) Tests with NULLS first combining with above two conditions.
4) Tests with combinations of using skip scan, NULLS first, DESC and SALT_BUCKETS.

> Range query on DECIMAL DESC sometimes incorrect
> -----------------------------------------------
>
>                 Key: PHOENIX-2137
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2137
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-2137.patch, PHOENIX-2137_wip.patch
>
>
> The following scenario is not working correctly:
> {code}
> create table t (k1 bigint not null, k2 decimal, constraint pk primary key (k1,k2 desc));
> upsert into t values(1,1.01);
> upsert into t values(2,1.001);
> select * from t where k2>1.0; -- No rows, but should be both rows
> select * from t where k1 in (1,2) and k2>1.0; -- Same problem
> {code}
> The following queries do return the correct results:
> {code}
> select * from t where k2>1.0001;
> select * from t where k1 in (1,2) and k2>1.0001;
> {code}
> Note also that without the DESC declaration of k2, everything works fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)