[GitHub] anirudh2290 commented on a change in pull request #12775: randn operator for symbol and NDarray API

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #12775: randn operator for symbol and NDarray API
URL: https://github.com/apache/incubator-mxnet/pull/12775#discussion_r231272398
 
 

 ##########
 File path: python/mxnet/ndarray/random.py
 ##########
 @@ -152,7 +152,7 @@ def normal(loc=0, scale=1, shape=_Null, dtype=_Null, ctx=None, out=None, **kwarg
                           [loc, scale], shape, dtype, ctx, out, kwargs)
 
 
-def randn(*shape, **kwargs):
+def randn(loc=0, scale=1, shape=_Null, dtype=_Null, ctx=None, out=None, **kwargs):
 
 Review comment:
   This seems to be a breaking change: For example mx.nd.random.randn(2, 3, loc=5, scale=1) will fail now. We should add this to APIs good to break for 2.0 https://github.com/apache/incubator-mxnet/issues/9686 and postpone this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services