[GitHub] [helix] jiajunwang commented on issue #2509: race condition in ZkClient may leave untracked watcher on ZK

["jiajunwang (via GitHub)" <gi...@apache.org>]

jiajunwang commented on issue #2509:
URL: https://github.com/apache/helix/issues/2509#issuecomment-1595054197

   Since the watcher is one-time, I don't think we consider this a leakage, right?
   
   Moreover, I suspect that if we can track all ZK watchers, and do we really need to do it? If user calls unsubscribeChildChanges 10 mins after subscribeChildChanges, the watcher will still become untracked, right?
   
   I assume the goal is to ensure all the existing watchers are tracked by _childListener map? For achieving this goal, I guess some GC mechanism works better. And in reality, the watchers only have a long life when they are watching non-exist paths (so no update), or very stable paths. Seems low risk to me. Do we have more detail about the potential user impact?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org