[GitHub] [ambari] eubnara commented on a diff in pull request #3352: AMBARI-25720. Support Apache Directory Server

[GitBox <gi...@apache.org>]

eubnara commented on code in PR #3352:
URL: https://github.com/apache/ambari/pull/3352#discussion_r1002653553


##########
ambari-web/app/controllers/main/admin/kerberos/step2_controller.js:
##########
@@ -164,8 +169,8 @@ App.KerberosWizardStep2Controller = App.WizardStep7Controller.extend(App.KDCCred
 
     typeSettings.configNames.forEach(function (_configName) {
       var config = configs.findProperty('name', _configName);
-      if (config) {
-        config.isVisible = kdcType === typeSettings.type;
+      if (config && (kdcType === typeSettings.type)) {
+        config.isVisible = true;

Review Comment:
   If this line is not changed, new bug will be introduced because `ldap_url`, `container_dn` is common for both 'ad' and 'ds' in `kerberosConfigMap`.
   Input box for `ldap_url` and `container_dn` will not be shown.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org