You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Webpal <gi...@git.apache.org> on 2016/10/13 11:54:13 UTC
[GitHub] cordova-plugin-file-transfer pull request #161: Allowing chunkedMode to be f...
GitHub user Webpal opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/161
Allowing chunkedMode to be false on Android / https
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
File uploads over https were automatically turned to Transfer-encoding: chunked due to old Android issues. Since adding this header to transfers often breaks functionality (for example you can't add an additional header to an Amazon S3 request that was signed without it) - isn't it better to follow the users instruction to use chunked mode or not instead of overwriting it?
### What testing has been done on this change?
Only deployed on one Android device, can not verify that it doesn't cause OOM issues - but this option is available as a setting for the user to controll in js.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Webpal/cordova-plugin-file-transfer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
----
commit e836377a0ff6e2fda810f65a8220413b2095a3ec
Author: Webpal <ni...@webpal.se>
Date: 2016-10-13T11:44:11Z
Update FileTransfer.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...
Posted by hey99xx <gi...@git.apache.org>.
Github user hey99xx commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/161
This can be closed, right? https://github.com/apache/cordova-plugin-file-transfer/commit/655489905ab5bd2600d4eaf80e8dd5d27e96b461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...
Posted by abihari <gi...@git.apache.org>.
Github user abihari commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/161
I ran into this issue while testing my app on an Android device as well. I modified the code similar to this PR and things work like they should. Please don't overwrite the chunkedMode setting that is being passed in from the JS side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...
Posted by jorgecasas <gi...@git.apache.org>.
Github user jorgecasas commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/161
I wasn't able to receive files in a PHP FastCGI server due it did not allowed chunkedMode if you were over HTTPS. With this patch it works now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer issue #161: Allowing chunkedMode to be false on...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/161
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org