[jira] [Issue Comment Edited] (CASSANDRA-3303) Short reads protection results in returning more columns than asked for

["Byron Clark (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139520#comment-13139520 ] 

Byron Clark edited comment on CASSANDRA-3303 at 11/1/11 2:58 PM:
-----------------------------------------------------------------

[^cassandra-3303-3.patch] should address all the concerns mentioned. 

I'm going to go ahead and pull some more of the logic out of StorageProxy and get rid of all the instanceof checks.
                
      was (Author: byronclark):
    [^casssandra-3303-3.patch] should address all the concerns mentioned. 

I'm going to go ahead and pull some more of the logic out of StorageProxy and get rid of all the instanceof checks.
                  
> Short reads protection results in returning more columns than asked for
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-3303
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3303
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Sylvain Lebresne
>            Assignee: Byron Clark
>            Priority: Minor
>             Fix For: 1.0.2
>
>         Attachments: cassandra-3303-1.patch, cassandra-3303-2.patch, cassandra-3303-3.patch, long_read.sh
>
>
> When we detect a short read (in SP.fetchRows), we retry a new command created by:
> {noformat}
> logger.debug("detected short read: expected {} columns, but only resolved {} columns", sliceCommand.count, liveColumnsInRow);
> int retryCount = sliceCommand.count + sliceCommand.count - liveColumnsInRow;
> SliceFromReadCommand retryCommand = new SliceFromReadCommand(command.table,
>                                                              command.key,
>                                                              command.queryPath,
>                                                              sliceCommand.start,
>                                                              sliceCommand.finish,
>                                                              sliceCommand.reversed,
>                                                              retryCount);
> {noformat}
> That is, in that new command, the count is greater than what asked in the initial command. But we never cut back the result of that new retried query.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira