You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/01 02:29:50 UTC

[GitHub] [incubator-inlong] KevinWen007 opened a new pull request #2795: [INLONG-2793][Sort] Fix bugs related to hive sink

KevinWen007 opened a new pull request #2795:
URL: https://github.com/apache/incubator-inlong/pull/2795


   ### Title Name: [INLONG-2793][Sort] Fix bugs related to hive sink
   
   Fixes #2793 
   
   ### Motivation
   
   Fix bugs related to hive sink
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] healchow commented on a change in pull request #2795: [INLONG-2793][Sort] Fix bugs related to hive sink

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2795:
URL: https://github.com/apache/incubator-inlong/pull/2795#discussion_r816424032



##########
File path: inlong-sort/sort-connectors/src/main/java/org/apache/inlong/sort/flink/filesystem/Bucket.java
##########
@@ -89,7 +89,13 @@ private Bucket(
         this.fsWriter = checkNotNull(fsWriter);
         this.subtaskIndex = subtaskIndex;
         this.bucketId = checkNotNull(bucketId);
-        this.bucketPath = checkNotNull(bucketPath);
+
+        String bucketPathStr = checkNotNull(bucketPath).toString();;

Review comment:
       Why two `;`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-inlong] dockerzhang merged pull request #2795: [INLONG-2793][Sort] Fix bugs related to hive sink

Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #2795:
URL: https://github.com/apache/incubator-inlong/pull/2795


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org