[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6043: [ARITH] Improve vector simplification for float operands

[GitBox <gi...@apache.org>]

merrymercy commented on a change in pull request #6043:
URL: https://github.com/apache/incubator-tvm/pull/6043#discussion_r454571390



##########
File path: src/arith/pattern_match.h
##########
@@ -145,6 +145,14 @@ class PEqualChecker<IntImm> {
   bool operator()(const IntImm& lhs, const IntImm& rhs) const { return lhs->value == rhs->value; }
 };
 
+template <>
+class PEqualChecker<FloatImm> {
+ public:
+  bool operator()(const FloatImm& lhs, const FloatImm& rhs) const {
+    return BaseValueEqual()(lhs->value, rhs->value);

Review comment:
       ```suggestion
       return BaseValueEqual()(rhs->value, lhs->value);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org