You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (Jira)" <ji...@apache.org> on 2020/07/02 15:53:00 UTC

[jira] [Resolved] (HTTPCLIENT-2095) Consider replacing concatenation into slf4j loggers with interpolation

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-2095.
-------------------------------------------
    Fix Version/s: 5.0.2
       Resolution: Fixed

> Consider replacing concatenation into slf4j loggers with interpolation
> ----------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2095
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2095
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCache
>    Affects Versions: 5.0.1
>            Reporter: Carter Kozak
>            Priority: Minor
>             Fix For: 5.0.2
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> In most cases these statements are protected by a conditional to check if the logger is enabled so there shouldn't be a real performance impact, replacing concatenation would result in code aligned with modern logging recommendations, and improve perf in a few cases that aren't guarded (though at a glance I don't see any in hot paths).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org