[jira] Issue Comment Edited: (SOLR-346) need to improve snapinstaller to ignore non-snapshots in data directory

["Steven Rowe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678137#action_12678137 ] 

steve_rowe edited comment on SOLR-346 at 3/2/09 2:39 PM:
----------------------------------------------------------

BTW, I tested the similar change made to snappuller under SOLR-830, and it does *not* have the same interpolation issue:

{code}
snap_name=`ssh -o StrictHostKeyChecking=no ${master_host} \
"perl -e 'chdir q|${master_data_dir}|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'"`
{code}

Since the shell script containing the perl script is enclosed in double quotes, ${master_data_dir} is properly interpolated before perl sees it.

      was (Author: steve_rowe):
    BTW, I tested the similar change made to snappuller under SOLR-830, and it does *not* have the same interpolation issue:

{code}
snap_name=`ssh -o StrictHostKeyChecking=no ${master_host} \
"perl -e 'chdir ${master_data_dir}|; print ((sort grep {/^snapshot[.][1-9][0-9]{13}$/} <*>)[-1])'"`
{code}

Since the perl script is enclosed in double quotes, ${master_data_dir} is properly interpolated before perl sees it.
  
> need to improve snapinstaller to ignore non-snapshots in data directory
> -----------------------------------------------------------------------
>
>                 Key: SOLR-346
>                 URL: https://issues.apache.org/jira/browse/SOLR-346
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (scripts)
>    Affects Versions: 1.2, 1.3
>            Reporter: Bill Au
>            Assignee: Bill Au
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: solr-346.patch
>
>
> http://www.mail-archive.com/solr-user@lucene.apache.org/msg05734.html
> > latest snapshot /opt/solr/data/temp-snapshot.20070816120113 already
> > installed
> A directory in the Solr data directory is causing snapinstaller to fail.  Snapinstaller should be improved to ignore any much non-snapshot as possible.  It can use a regular expression to look for snapshot.dddddddddddddd where d is a digit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.