[GitHub] srowen commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline

[GitBox <gi...@apache.org>]

srowen commented on issue #23263: [SPARK-23674][ML] Adds Spark ML Events to Pipeline
URL: https://github.com/apache/spark/pull/23263#issuecomment-447885870
 
 
   I guess I mean, why does the event have to be fired from within each class's implementation, in fit or fitImpl? what about firing it when Pipeline calls any fit() method, etc? You could also capture events from all the elements in the pipeline without instrumenting every implementation. It's more than this change, which looks fine, but seems like it would capture the functionality you had in the original change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org