You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Aniket Mokashi <an...@gmail.com> on 2013/10/20 18:46:18 UTC
Review Request 14775: PIG-3325 Adding a tuple to a bag is slow
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14775/
-----------------------------------------------------------
Review request for pig, Dmitriy Ryaboy, Julien Le Dem, and Mark Wagner.
Bugs: PIG-3325
https://issues.apache.org/jira/browse/PIG-3325
Repository: pig
Description
-------
Adding a tuple to a bag is slow
- Fixed issue with sampling and minor edits in comments.
Diffs
-----
trunk/src/org/apache/pig/data/DefaultAbstractBag.java 1531787
Diff: https://reviews.apache.org/r/14775/diff/
Testing
-------
test-commit, TestDataBag, TestDataBagAccess pass.
Thanks,
Aniket Mokashi
Re: Review Request 14775: PIG-3325 Adding a tuple to a bag is slow
Posted by Cheolsoo Park <pi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14775/#review27277
-----------------------------------------------------------
Ship it!
LGTM! Thank you Aniket!
- Cheolsoo Park
On Oct. 21, 2013, 2:53 a.m., Aniket Mokashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14775/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 2:53 a.m.)
>
>
> Review request for pig, Cheolsoo Park, Dmitriy Ryaboy, Julien Le Dem, and Mark Wagner.
>
>
> Bugs: PIG-3325
> https://issues.apache.org/jira/browse/PIG-3325
>
>
> Repository: pig
>
>
> Description
> -------
>
> Adding a tuple to a bag is slow
> - Fixed issue with sampling and minor edits in comments.
>
>
> Diffs
> -----
>
> trunk/src/org/apache/pig/data/DefaultAbstractBag.java 1531787
>
> Diff: https://reviews.apache.org/r/14775/diff/
>
>
> Testing
> -------
>
> test-commit, TestDataBag, TestDataBagAccess pass.
>
>
> Thanks,
>
> Aniket Mokashi
>
>
Re: Review Request 14775: PIG-3325 Adding a tuple to a bag is slow
Posted by Aniket Mokashi <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14775/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 2:53 a.m.)
Review request for pig, Cheolsoo Park, Dmitriy Ryaboy, Julien Le Dem, and Mark Wagner.
Bugs: PIG-3325
https://issues.apache.org/jira/browse/PIG-3325
Repository: pig
Description
-------
Adding a tuple to a bag is slow
- Fixed issue with sampling and minor edits in comments.
Diffs
-----
trunk/src/org/apache/pig/data/DefaultAbstractBag.java 1531787
Diff: https://reviews.apache.org/r/14775/diff/
Testing
-------
test-commit, TestDataBag, TestDataBagAccess pass.
Thanks,
Aniket Mokashi