Re: [PR] RATIS-2147. MD5 mismatch when accept snapshot [ratis]

["133tosakarin (via GitHub)" <gi...@apache.org>]

133tosakarin commented on code in PR #1142:
URL: https://github.com/apache/ratis/pull/1142#discussion_r1742436405


##########
ratis-server/src/main/java/org/apache/ratis/server/storage/SnapshotManager.java:
##########
@@ -114,7 +115,8 @@ public void installSnapshot(InstallSnapshotRequestProto request, StateMachine st
 
     // TODO: Make sure that subsequent requests for the same installSnapshot are coming in order,
     // and are not lost when whole request cycle is done. Check requestId and requestIndex here
-
+    MessageDigest digester = newMd5Digest();
+    digester.reset();

Review Comment:
   Since I am not sure if it is a problem with JavaUtils.memoize, but I can confirm that it is a problem with digest, my idea is to use a new digest each time, which is more secure and reliable, and also avoids the situation where the digest calculation buffer is destroyed and the final result is incorrect



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org