You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/21 05:40:48 UTC

[GitHub] [apisix-dashboard] ShiningRush opened a new pull request #844: feat: add a unit test for consumer and remove implicit init

ShiningRush opened a new pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844


   - add a real unit test for consumer `Get`
   - remove implicit init function, go is not recommended.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #844: feat: add a unit test for consumer and remove implicit init

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844#issuecomment-732014045


   It seems that there have a lot of changes with the master branch, maybe related to squash?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] ShiningRush commented on pull request #844: feat: add a unit test for consumer and remove implicit init

Posted by GitBox <gi...@apache.org>.
ShiningRush commented on pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844#issuecomment-732115934


   I open a new PR(#859 ) for it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] ShiningRush closed pull request #844: feat: add a unit test for consumer and remove implicit init

Posted by GitBox <gi...@apache.org>.
ShiningRush closed pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #844: feat: add a unit test for consumer and remove implicit init

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844#issuecomment-732098356


   emmm may need cherry-pick


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #844: feat: add a unit test for consumer and remove implicit init

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844#issuecomment-731515599


   Good job.Thanks.
   
   We need to enable CI for v2.1 to test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #844: feat: add a unit test for consumer and remove implicit init

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #844:
URL: https://github.com/apache/apisix-dashboard/pull/844#issuecomment-731987609


   @ShiningRush  
   
   please change base to `master`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org