You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/11/16 20:10:29 UTC

Review Request 74741: RANGER-4530: fixed GDS update APIs to not require guid in payload

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74741/
-----------------------------------------------------------

Review request for ranger, Anand Nadar, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Mugdha Varadkar, Prashant Satam, Ramesh Mani, and Subhrat Chaudhary.


Bugs: RANGER-4530
    https://issues.apache.org/jira/browse/RANGER-4530


Repository: ranger


Description
-------

- updated APIs to copy GUID value from existing object
- removed unnecessary annotation from GET API calls: @Consumes({ "application/json" })


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 6390f0547 
  security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java b1dc9d37d 


Diff: https://reviews.apache.org/r/74741/diff/1/


Testing
-------

- verified that update calls succeed even when GUID is not provided in the payload


Thanks,

Madhan Neethiraj


Re: Review Request 74741: RANGER-4530: fixed GDS update APIs to not require guid in payload

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74741/#review225962
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Nov. 16, 2023, 8:10 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74741/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2023, 8:10 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Mugdha Varadkar, Prashant Satam, Ramesh Mani, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4530
>     https://issues.apache.org/jira/browse/RANGER-4530
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - updated APIs to copy GUID value from existing object
> - removed unnecessary annotation from GET API calls: @Consumes({ "application/json" })
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 6390f0547 
>   security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java b1dc9d37d 
> 
> 
> Diff: https://reviews.apache.org/r/74741/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that update calls succeed even when GUID is not provided in the payload
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>