You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/14 02:09:20 UTC
[james-project] 03/32: [Refactoring] StatusProcessor: Avoid final
variables
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 141faa52c2eeedb92b68c2254e11acd58f98a02f
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Wed Nov 13 11:20:03 2019 +0700
[Refactoring] StatusProcessor: Avoid final variables
---
.../james/imap/processor/StatusProcessor.java | 30 +++++++++++-----------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
index 5355051..5dd0ab4 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
@@ -53,35 +53,35 @@ public class StatusProcessor extends AbstractMailboxProcessor<StatusRequest> {
@Override
protected void doProcess(StatusRequest request, ImapSession session, Tag tag, ImapCommand command, Responder responder) {
- final MailboxPath mailboxPath = PathConverter.forSession(session).buildFullPath(request.getMailboxName());
- final StatusDataItems statusDataItems = request.getStatusDataItems();
- final MailboxSession mailboxSession = ImapSessionUtils.getMailboxSession(session);
+ MailboxPath mailboxPath = PathConverter.forSession(session).buildFullPath(request.getMailboxName());
+ StatusDataItems statusDataItems = request.getStatusDataItems();
+ MailboxSession mailboxSession = ImapSessionUtils.getMailboxSession(session);
try {
LOGGER.debug("Status called on mailbox named {}", mailboxPath);
- final MailboxManager mailboxManager = getMailboxManager();
- final MessageManager mailbox = mailboxManager.getMailbox(mailboxPath, ImapSessionUtils.getMailboxSession(session));
- final MessageManager.MetaData.FetchGroup fetchGroup;
+ MailboxManager mailboxManager = getMailboxManager();
+ MessageManager mailbox = mailboxManager.getMailbox(mailboxPath, ImapSessionUtils.getMailboxSession(session));
+ MessageManager.MetaData.FetchGroup fetchGroup;
if (statusDataItems.isUnseen()) {
fetchGroup = MessageManager.MetaData.FetchGroup.UNSEEN_COUNT;
} else {
fetchGroup = MessageManager.MetaData.FetchGroup.NO_UNSEEN;
}
- final MessageManager.MetaData metaData = mailbox.getMetaData(false, mailboxSession, fetchGroup);
-
- final Long messages = messages(statusDataItems, metaData);
- final Long recent = recent(statusDataItems, metaData);
- final MessageUid uidNext = uidNext(statusDataItems, metaData);
- final Long uidValidity = uidValidity(statusDataItems, metaData);
- final Long unseen = unseen(statusDataItems, metaData);
- final Long highestModSeq = highestModSeq(statusDataItems, metaData);
+ MessageManager.MetaData metaData = mailbox.getMetaData(false, mailboxSession, fetchGroup);
+
+ Long messages = messages(statusDataItems, metaData);
+ Long recent = recent(statusDataItems, metaData);
+ MessageUid uidNext = uidNext(statusDataItems, metaData);
+ Long uidValidity = uidValidity(statusDataItems, metaData);
+ Long unseen = unseen(statusDataItems, metaData);
+ Long highestModSeq = highestModSeq(statusDataItems, metaData);
// Enable CONDSTORE as this is a CONDSTORE enabling command
if (highestModSeq != null) {
condstoreEnablingCommand(session, responder, metaData, false);
}
- final MailboxStatusResponse response = new MailboxStatusResponse(messages, recent, uidNext, highestModSeq, uidValidity, unseen, request.getMailboxName());
+ MailboxStatusResponse response = new MailboxStatusResponse(messages, recent, uidNext, highestModSeq, uidValidity, unseen, request.getMailboxName());
responder.respond(response);
unsolicitedResponses(session, responder, false);
okComplete(command, tag, responder);
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org