You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/11 05:54:41 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request #8005: add SQLServer with clause for delete statement.
dongzl opened a new pull request #8005:
URL: https://github.com/apache/shardingsphere/pull/8005
For #6478 .
Changes proposed in this pull request:
- add SQLServer with clause for delete statement.
- add SQLServer test case for delete with clause.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #8005: add SQLServer with clause for delete statement.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8005:
URL: https://github.com/apache/shardingsphere/pull/8005#issuecomment-725284726
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=h1) Report
> Merging [#8005](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=desc) (d419f11) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e6f3153f45a53e74daa82a00b5ac8d81e19a8986?el=desc) (e6f3153) will **decrease** coverage by `0.01%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8005 +/- ##
============================================
- Coverage 75.15% 75.14% -0.02%
Complexity 538 538
============================================
Files 1446 1446
Lines 22735 22741 +6
Branches 4072 4074 +2
============================================
+ Hits 17087 17088 +1
- Misses 4530 4534 +4
- Partials 1118 1119 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ql/dialect/handler/dml/DeleteStatementHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8005/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9oYW5kbGVyL2RtbC9EZWxldGVTdGF0ZW1lbnRIYW5kbGVyLmphdmE=) | `16.66% <0.00%> (-5.56%)` | `0.00 <0.00> (ø)` | |
| [...tement/sqlserver/dml/SQLServerDeleteStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/8005/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvc3Fsc2VydmVyL2RtbC9TUUxTZXJ2ZXJEZWxldGVTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tatement/impl/SQLServerDMLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/8005/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvU1FMU2VydmVyRE1MU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `85.95% <100.00%> (+0.09%)` | `0.00 <0.00> (ø)` | |
| [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8005/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=footer). Last update [e6f3153...d419f11](https://codecov.io/gh/apache/shardingsphere/pull/8005?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl removed a comment on pull request #8005: add SQLServer with clause for delete statement.
Posted by GitBox <gi...@apache.org>.
dongzl removed a comment on pull request #8005:
URL: https://github.com/apache/shardingsphere/pull/8005#issuecomment-720087444
The 5.x version will release, now I will close this PR, and reopen it after the 5.x be released.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #8005: add SQLServer with clause for delete statement.
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #8005:
URL: https://github.com/apache/shardingsphere/pull/8005
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org