You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jonathan Carlson <jo...@yahoo.com> on 2002/10/31 22:28:51 UTC
[Collections] IteratorChain bug
The 2.1 collections release is very cool. Thanks.
I just found a bug in the 2.1 IteratorChain implementation
of Iterator. The TestIteratorChain class doesn't appear to
test the following situation:
If the first iterator has no elements and the second does,
then the hasNext() method returns false the first time it
is called. However, it should return true because the
second iterator has items.
Thanks!
Jonathan Carlson
Minneapolis, Minnesota
=====
Jonathan Carlson
joncrlsn@users.sf.net
Minneapolis, Minnesota
__________________________________________________
Do you Yahoo!?
HotJobs - Search new jobs daily now
http://hotjobs.yahoo.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Collections] IteratorChain bug
Posted by Morgan Delagrange <md...@yahoo.com>.
I was about to commit exactly the same change. And
your unit test is better, you bastard. ;)
- Morgan
--- Rodney Waldhoff <rw...@apache.org> wrote:
> I think I beat you to it, but please review.
>
> On Thu, 31 Oct 2002, Morgan Delagrange wrote:
>
> > Good point, I believe you are correct just looking
> at
> > the source. Looks like it's pretty easy to fix,
> so
> > I'll try to do so.
> >
> > - Morgan
> >
> > --- Jonathan Carlson <jo...@yahoo.com> wrote:
> > > The 2.1 collections release is very cool.
> Thanks.
> > >
> > > I just found a bug in the 2.1 IteratorChain
> > > implementation
> > > of Iterator. The TestIteratorChain class
> doesn't
> > > appear to
> > > test the following situation:
> > >
> > > If the first iterator has no elements and the
> second
> > > does,
> > > then the hasNext() method returns false the
> first
> > > time it
> > > is called. However, it should return true
> because
> > > the
> > > second iterator has items.
> > >
> > > Thanks!
> > >
> > > Jonathan Carlson
> > > Minneapolis, Minnesota
> > >
> > > =====
> > > Jonathan Carlson
> > > joncrlsn@users.sf.net
> > > Minneapolis, Minnesota
> > >
> > >
> __________________________________________________
> > > Do you Yahoo!?
> > > HotJobs - Search new jobs daily now
> > > http://hotjobs.yahoo.com/
> > >
> > > --
> > > To unsubscribe, e-mail:
> > >
> <ma...@jakarta.apache.org>
> > > For additional commands, e-mail:
> > > <ma...@jakarta.apache.org>
> > >
> >
> >
> > =====
> > Morgan Delagrange
> > http://jakarta.apache.org/taglibs
> > http://jakarta.apache.org/commons
> > http://axion.tigris.org
> > http://jakarta.apache.org/watchdog
> >
> > __________________________________________________
> > Do you Yahoo!?
> > HotJobs - Search new jobs daily now
> > http://hotjobs.yahoo.com/
> >
> > --
> > To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> <ma...@jakarta.apache.org>
> >
> >
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
=====
Morgan Delagrange
http://jakarta.apache.org/taglibs
http://jakarta.apache.org/commons
http://axion.tigris.org
http://jakarta.apache.org/watchdog
__________________________________________________
Do you Yahoo!?
HotJobs - Search new jobs daily now
http://hotjobs.yahoo.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Collections] IteratorChain bug
Posted by Rodney Waldhoff <rw...@apache.org>.
I think I beat you to it, but please review.
On Thu, 31 Oct 2002, Morgan Delagrange wrote:
> Good point, I believe you are correct just looking at
> the source. Looks like it's pretty easy to fix, so
> I'll try to do so.
>
> - Morgan
>
> --- Jonathan Carlson <jo...@yahoo.com> wrote:
> > The 2.1 collections release is very cool. Thanks.
> >
> > I just found a bug in the 2.1 IteratorChain
> > implementation
> > of Iterator. The TestIteratorChain class doesn't
> > appear to
> > test the following situation:
> >
> > If the first iterator has no elements and the second
> > does,
> > then the hasNext() method returns false the first
> > time it
> > is called. However, it should return true because
> > the
> > second iterator has items.
> >
> > Thanks!
> >
> > Jonathan Carlson
> > Minneapolis, Minnesota
> >
> > =====
> > Jonathan Carlson
> > joncrlsn@users.sf.net
> > Minneapolis, Minnesota
> >
> > __________________________________________________
> > Do you Yahoo!?
> > HotJobs - Search new jobs daily now
> > http://hotjobs.yahoo.com/
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> =====
> Morgan Delagrange
> http://jakarta.apache.org/taglibs
> http://jakarta.apache.org/commons
> http://axion.tigris.org
> http://jakarta.apache.org/watchdog
>
> __________________________________________________
> Do you Yahoo!?
> HotJobs - Search new jobs daily now
> http://hotjobs.yahoo.com/
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [Collections] IteratorChain bug
Posted by Morgan Delagrange <md...@yahoo.com>.
Good point, I believe you are correct just looking at
the source. Looks like it's pretty easy to fix, so
I'll try to do so.
- Morgan
--- Jonathan Carlson <jo...@yahoo.com> wrote:
> The 2.1 collections release is very cool. Thanks.
>
> I just found a bug in the 2.1 IteratorChain
> implementation
> of Iterator. The TestIteratorChain class doesn't
> appear to
> test the following situation:
>
> If the first iterator has no elements and the second
> does,
> then the hasNext() method returns false the first
> time it
> is called. However, it should return true because
> the
> second iterator has items.
>
> Thanks!
>
> Jonathan Carlson
> Minneapolis, Minnesota
>
> =====
> Jonathan Carlson
> joncrlsn@users.sf.net
> Minneapolis, Minnesota
>
> __________________________________________________
> Do you Yahoo!?
> HotJobs - Search new jobs daily now
> http://hotjobs.yahoo.com/
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
=====
Morgan Delagrange
http://jakarta.apache.org/taglibs
http://jakarta.apache.org/commons
http://axion.tigris.org
http://jakarta.apache.org/watchdog
__________________________________________________
Do you Yahoo!?
HotJobs - Search new jobs daily now
http://hotjobs.yahoo.com/
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>