You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/02/10 01:28:41 UTC
[GitHub] [zookeeper] iamgd67 opened a new pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
iamgd67 opened a new pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814
zooinspect logback config file `logback.xml` currently use a pattern of this
`<pattern>%5p [%t] (%F:%L) - %m%n</pattern> `
which not escape the '(' and ')', cause logback to ignore parts after ')'.
according to logback documents, '(' and ')' is used for grouping, need escape by '\' if used as normal char
https://logback.qos.ch/manual/layouts.html#grouping
this pr update it to (add '\' to escape)
`<pattern>%5p [%t] \(%F:%L\) - %m%n</pattern> `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1039961028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1040160580
CI failed again, but with different test failure this time:
```
[ERROR] Failures:
[ERROR] ReconfigRollingRestartCompatibilityTest.testRollingRestartWithExtendedMembershipConfig:263 waiting for server 2 being up ==> expected: <true> but was: <false>
[INFO]
[ERROR] Tests run: 2976, Failures: 1, Errors: 0, Skipped: 4
```
we have many flaky tests apparently... anyway, I'm merging this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1039878828
@eolivelli could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1039962424
@anmolnar can you take a look?
(we should merge this to master, branch-3.8 and branch-3.8.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1040087920
we had one java unit test failure (all c++ tests passed this time).
```
[ERROR] EagerACLFilterTest.testCreate2Fail:171->assertTransactionState:115 Server State: OBSERVING Check Enabled: true Transaction state on Leader after failed create2 ==> expected: <4294967298> but was: <4294967299>
```
I don't see how this test failure could connect to the PR, but to be on the safe side I re-triggered CI. I will merge if the CI is green (or at least this single failing test become green).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1040166011
@iamgd67, thanks for the contribution again!
PR merged to branches:
- master
- branch-3.8
- branch-3.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1039878828
@eolivelli could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1038943461
@anmolnar likelly the broken is from #1807 which change log4j to logback, can you review this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1039961028
cool, thanks @iamgd67 for the contribution! This would be great to land in 3.8.0 where we will migrate to logback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] iamgd67 commented on pull request #1814: ZOOKEEPER-4465: zooinspector logback pattern config add escape for '(' and ')'
Posted by GitBox <gi...@apache.org>.
iamgd67 commented on pull request #1814:
URL: https://github.com/apache/zookeeper/pull/1814#issuecomment-1038579742
@symat could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org