You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Robert Chansler (JIRA)" <ji...@apache.org> on 2008/10/22 02:44:44 UTC
[jira] Updated: (HADOOP-3640) NativeS3FsInputStream read() method
for reading a single byte is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-3640:
------------------------------------
Component/s: fs/s3
> NativeS3FsInputStream read() method for reading a single byte is incorrect
> --------------------------------------------------------------------------
>
> Key: HADOOP-3640
> URL: https://issues.apache.org/jira/browse/HADOOP-3640
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs/s3
> Affects Versions: 0.18.0
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.19.0
>
> Attachments: hadoop-3640.patch
>
>
> From Albert Chern:
> I think there may be a bug in the read() method of NativeS3InputStream, which looks like this:
> {code}
> public synchronized int read() throws IOException {
> int result = in.read();
> if (result > 0) {
> pos += result;
> }
> return result;
> }
> {code}
> The return value of InputStream.read() should be the next byte in the range 0 to 255, or -1 if there are no more bytes. So shouldn't this method look something like this?
> {code}
> public synchronized int read() throws IOException {
> int result = in.read();
> if (result > -1) {
> pos ++;
> }
> return result;
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.