You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/10/12 13:57:04 UTC
Review Request 62934: Set current_version for Backward Compatibility
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko and Nate Cole.
Bugs: AMBARI-22219
https://issues.apache.org/jira/browse/AMBARI-22219
Repository: ambari
Description
-------
Some stacks, mpacks, and extension services may have been relying on the deprecated and removed {{hostLevelParams/current_version}}. Although this value was removed since there is no longer a single version for the cluster, we can continue to set it using the version of the repository associated with the current command.
This will allow existing mpacks and services which were relying on this value to continue to using it until they can switch over to {{componentVersionMapping}} structure.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java f37bdd5e6f
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6ffc9c11b3
Diff: https://reviews.apache.org/r/62934/diff/1/
Testing
-------
Manual.
Thanks,
Jonathan Hurley
Re: Review Request 62934: Set current_version for Backward
Compatibility
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/#review187795
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Oct. 12, 2017, 9:57 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62934/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 9:57 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-22219
> https://issues.apache.org/jira/browse/AMBARI-22219
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some stacks, mpacks, and extension services may have been relying on the deprecated and removed {{hostLevelParams/current_version}}. Although this value was removed since there is no longer a single version for the cluster, we can continue to set it using the version of the repository associated with the current command.
>
> This will allow existing mpacks and services which were relying on this value to continue to using it until they can switch over to {{componentVersionMapping}} structure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java f37bdd5e6f
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6ffc9c11b3
>
>
> Diff: https://reviews.apache.org/r/62934/diff/1/
>
>
> Testing
> -------
>
> Manual.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 62934: Set current_version for Backward
Compatibility
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/#review187796
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On Oct. 12, 2017, 1:57 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62934/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2017, 1:57 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
>
>
> Bugs: AMBARI-22219
> https://issues.apache.org/jira/browse/AMBARI-22219
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some stacks, mpacks, and extension services may have been relying on the deprecated and removed {{hostLevelParams/current_version}}. Although this value was removed since there is no longer a single version for the cluster, we can continue to set it using the version of the repository associated with the current command.
>
> This will allow existing mpacks and services which were relying on this value to continue to using it until they can switch over to {{componentVersionMapping}} structure.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java f37bdd5e6f
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java 6ffc9c11b3
>
>
> Diff: https://reviews.apache.org/r/62934/diff/1/
>
>
> Testing
> -------
>
> Audit done.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:43 min
> [INFO] Finished at: 2017-10-12T10:38:56-04:00
> [INFO] Final Memory: 71M/881M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>