[jira] Reopened: (XMLRPC-141) XmlRpcRequestParser doesn't reset params on startDocument so instance can't be reused.

["keith mcneill (JIRA)" <xm...@ws.apache.org>]

     [ https://issues.apache.org/jira/browse/XMLRPC-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

keith mcneill reopened XMLRPC-141:
----------------------------------


Thanks for the fix.  Today, just after you fixed that I found that the XmlRpcResponseParser has the same issue.  You cannot reuse it.  Here is the patch for that:

Index: common/src/main/java/org/apache/xmlrpc/parser/XmlRpcResponseParser.java
===================================================================
--- common/src/main/java/org/apache/xmlrpc/parser/XmlRpcResponseParser.java     (revision 538616)
+++ common/src/main/java/org/apache/xmlrpc/parser/XmlRpcResponseParser.java     (working copy)
@@ -69,6 +69,9 @@
        public void startDocument() throws SAXException {
                super.startDocument();
                level = 0;
+        isSuccess = false;
+        errorCode = 0;
+        errorMessage = null;
        }
 
        public void startElement(String pURI, String pLocalName, String pQName,


> XmlRpcRequestParser doesn't reset params on startDocument so instance can't be reused.
> --------------------------------------------------------------------------------------
>
>                 Key: XMLRPC-141
>                 URL: https://issues.apache.org/jira/browse/XMLRPC-141
>             Project: XML-RPC
>          Issue Type: Bug
>            Reporter: keith mcneill
>         Assigned To: Jochen Wiedmann
>             Fix For: 3.1
>
>
> XmlRpcRequestParser doesn't reset params on startDocument so instance can't be reused.
> Here is a patch against 3.0:
> >>> svn diff XMLRPC_3_0_BRANCH/
> Index: XMLRPC_3_0_BRANCH/common/src/main/java/org/apache/xmlrpc/parser/XmlRpcRequestParser.java
> ===================================================================
> --- XMLRPC_3_0_BRANCH/common/src/main/java/org/apache/xmlrpc/parser/XmlRpcRequestParser.java    (revision 526761)
> +++ XMLRPC_3_0_BRANCH/common/src/main/java/org/apache/xmlrpc/parser/XmlRpcRequestParser.java    (working copy)
> @@ -54,6 +54,7 @@
>                 level = 0;
>                 inMethodName = false;
>                 methodName = null;
> +        params = null;
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.