You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/08/26 02:27:03 UTC
[kudu-CR] tools: wrap descriptions
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4130
to review the following change.
Change subject: tools: wrap descriptions
......................................................................
tools: wrap descriptions
Wraps the help and usage output on a 78-column width so that it's much more
readable.
New output:
todd@todd-ThinkPad-T540p:~/git/kudu$ ./build/latest/bin/kudu cluster
Usage: ./build/latest/bin/kudu cluster <command> [<args>]
<command> can be one of the following:
ksck Check the health of a Kudu cluster. By default, ksck checks that
master and tablet server processes are running, and that table
metadata is consistent. Use the 'checksum' flag to check that tablet
data is consistent (also see the 'tables' and 'tablets' flags). Use
the 'checksum_snapshot' along with 'checksum' if the table or tablets
are actively receiving inserts or updates.
todd@todd-ThinkPad-T540p:~/git/kudu$ ./build/latest/bin/kudu cluster ksck --help
Usage: ./build/latest/bin/kudu cluster ksck <master_address> [-checksum_scan]
[-nochecksum_snapshot] [-tables=<tables>] [-tablets=<tablets>]
[-color=<color>]
Check the health of a Kudu cluster. By default, ksck checks that master and
tablet server processes are running, and that table metadata is consistent.
Use the 'checksum' flag to check that tablet data is consistent (also see the
'tables' and 'tablets' flags). Use the 'checksum_snapshot' along with
'checksum' if the table or tablets are actively receiving inserts or updates.
master_address (Kudu Master RPC address of form hostname:port)
type: string default: ""
-checksum_scan (Perform a checksum scan on data in the cluster.) type: bool
default: false
-checksum_snapshot (Should the checksum scanner use a snapshot scan)
type: bool default: true
-tables (Tables to check (comma-separated list of names). If not specified,
checks all tables.) type: string default: ""
-tablets (Tablets to check (comma-separated list of IDs) If not specified,
checks all tablets.) type: string default: ""
-color (Specifies whether ksck output is colorized. The default value
'auto' colorizes output if the output is a terminal. The other valid
values are 'always' or 'never'.) type: string default: "auto"
Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
---
M src/kudu/tools/tool_action.cc
1 file changed, 58 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/4130/1
--
To view, visit http://gerrit.cloudera.org:8080/4130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] tools: wrap descriptions
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tools: wrap descriptions
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3082/
--
To view, visit http://gerrit.cloudera.org:8080/4130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] tools: wrap descriptions
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: tools: wrap descriptions
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3083/
--
To view, visit http://gerrit.cloudera.org:8080/4130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] tools: wrap descriptions
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: tools: wrap descriptions
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4130/2//COMMIT_MSG
Commit Message:
PS2, Line 18: ksck Check the health of a Kudu cluster. By default, ksck checks that
: master and tablet server processes are running, and that table
: metadata is consistent. Use the 'checksum' flag to check that tablet
: data is consistent (also see the 'tables' and 'tablets' flags). Use
: the 'checksum_snapshot' along with 'checksum' if the table or tablets
: are actively receiving inserts or updates.
> So you don't think it's worth distinguishing between short and long descrip
I do, but didn't want to do that in this commit. Even for "short" descriptions we may want to wrap.
--
To view, visit http://gerrit.cloudera.org:8080/4130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] tools: wrap descriptions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tools: wrap descriptions
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4130/2//COMMIT_MSG
Commit Message:
PS2, Line 18: ksck Check the health of a Kudu cluster. By default, ksck checks that
: master and tablet server processes are running, and that table
: metadata is consistent. Use the 'checksum' flag to check that tablet
: data is consistent (also see the 'tables' and 'tablets' flags). Use
: the 'checksum_snapshot' along with 'checksum' if the table or tablets
: are actively receiving inserts or updates.
So you don't think it's worth distinguishing between short and long descriptions for this case?
--
To view, visit http://gerrit.cloudera.org:8080/4130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] tools: wrap descriptions
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: tools: wrap descriptions
......................................................................
tools: wrap descriptions
Wraps the help and usage output on a 78-column width so that it's much more
readable.
New output:
todd@todd-ThinkPad-T540p:~/git/kudu$ ./build/latest/bin/kudu cluster
Usage: ./build/latest/bin/kudu cluster <command> [<args>]
<command> can be one of the following:
ksck Check the health of a Kudu cluster. By default, ksck checks that
master and tablet server processes are running, and that table
metadata is consistent. Use the 'checksum' flag to check that tablet
data is consistent (also see the 'tables' and 'tablets' flags). Use
the 'checksum_snapshot' along with 'checksum' if the table or tablets
are actively receiving inserts or updates.
todd@todd-ThinkPad-T540p:~/git/kudu$ ./build/latest/bin/kudu cluster ksck --help
Usage: ./build/latest/bin/kudu cluster ksck <master_address> [-checksum_scan]
[-nochecksum_snapshot] [-tables=<tables>] [-tablets=<tablets>]
[-color=<color>]
Check the health of a Kudu cluster. By default, ksck checks that master and
tablet server processes are running, and that table metadata is consistent.
Use the 'checksum' flag to check that tablet data is consistent (also see the
'tables' and 'tablets' flags). Use the 'checksum_snapshot' along with
'checksum' if the table or tablets are actively receiving inserts or updates.
master_address (Kudu Master RPC address of form hostname:port)
type: string default: ""
-checksum_scan (Perform a checksum scan on data in the cluster.) type: bool
default: false
-checksum_snapshot (Should the checksum scanner use a snapshot scan)
type: bool default: true
-tables (Tables to check (comma-separated list of names). If not specified,
checks all tables.) type: string default: ""
-tablets (Tablets to check (comma-separated list of IDs) If not specified,
checks all tablets.) type: string default: ""
-color (Specifies whether ksck output is colorized. The default value
'auto' colorizes output if the output is a terminal. The other valid
values are 'always' or 'never'.) type: string default: "auto"
Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Reviewed-on: http://gerrit.cloudera.org:8080/4130
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/tool_action.cc
1 file changed, 58 insertions(+), 9 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie63b72e1e1a3479819730c348f5a0f00a7164d02
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>