You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by HuangWHWHW <gi...@git.apache.org> on 2015/08/08 03:38:20 UTC
[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/1001
[FLINK-2500][Streaming]remove a unwanted "if" branch
This "if" is pointless since the "for" will do the same check.
And add a new temporary var(int size) so that “dataStream.unionedStreams.size()” will just be called once.
Instead "dataStream.unionedStreams.size()" will be called every time when "i++" and it do harm to the performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HuangWHWHW/flink FLINK-2500
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1001.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1001
----
commit ed3bc7e07f0a40f14b06ca11874799d921772101
Author: HuangWHWHW <40...@qq.com>
Date: 2015-08-08T01:31:08Z
[FLINK-2500][Streaming]remove a unwanted "if" branch
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1001
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1001#issuecomment-129358588
I'm going to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1001#issuecomment-129449346
Thank you!
And there are other two PRs(https://github.com/apache/flink/pull/992 and https://github.com/apache/flink/pull/977).
It has been days that no one cared more.
Would you like to have a look??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1001#issuecomment-128949528
These are just API calls so performance is not an issue here. We should focus more on the readability.
Your change does not do any harm in that sense so I guess it is okay to merge from my side.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2500][Streaming]remove a unwanted "if" ...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1001#issuecomment-129328760
Your changes will have very little impact on the performance. However, they are semantically correct and can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---