You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/12 16:14:12 UTC
[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #1038: [SeaTunnel #1037] Add InfluxDB Flink Sink
asdf2014 opened a new pull request #1038:
URL: https://github.com/apache/incubator-seatunnel/pull/1038
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
Fixes #1037
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] garyelephant merged pull request #1038: [SeaTunnel #1037] Add InfluxDB Flink Sink
Posted by GitBox <gi...@apache.org>.
garyelephant merged pull request #1038:
URL: https://github.com/apache/incubator-seatunnel/pull/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1038: [SeaTunnel #1037] Add InfluxDB Flink Sink
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1038:
URL: https://github.com/apache/incubator-seatunnel/pull/1038#discussion_r783675841
##########
File path: pom.xml
##########
@@ -427,6 +428,12 @@
<artifactId>config</artifactId>
<version>${config.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.influxdb</groupId>
+ <artifactId>influxdb-java</artifactId>
+ <version>${influxdb-java.version}</version>
+ </dependency>
Review comment:
> This is allowed, you can refer to this https://apache.org/legal/resolved.html
OK, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] garyelephant commented on pull request #1038: [SeaTunnel #1037] Add InfluxDB Flink Sink
Posted by GitBox <gi...@apache.org>.
garyelephant commented on pull request #1038:
URL: https://github.com/apache/incubator-seatunnel/pull/1038#issuecomment-1012768387
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1038: [SeaTunnel #1037] Add InfluxDB Flink Sink
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1038:
URL: https://github.com/apache/incubator-seatunnel/pull/1038#discussion_r783640201
##########
File path: pom.xml
##########
@@ -427,6 +428,12 @@
<artifactId>config</artifactId>
<version>${config.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.influxdb</groupId>
+ <artifactId>influxdb-java</artifactId>
+ <version>${influxdb-java.version}</version>
+ </dependency>
Review comment:
This dependency seems to be the MIT open source license, does it conflict with the Apache open source license? If there is no conflict, whether to add relevant instructions in the declaration file, please check. @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1038: [SeaTunnel #1037] Add InfluxDB Flink Sink
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1038:
URL: https://github.com/apache/incubator-seatunnel/pull/1038#discussion_r783649669
##########
File path: pom.xml
##########
@@ -427,6 +428,12 @@
<artifactId>config</artifactId>
<version>${config.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.influxdb</groupId>
+ <artifactId>influxdb-java</artifactId>
+ <version>${influxdb-java.version}</version>
+ </dependency>
Review comment:
This is allowed, you can refer to this https://apache.org/legal/resolved.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org