You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/06/10 21:58:41 UTC
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Hello Alexey Serbin, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13578
to review the following change.
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
hms: clarify message to pass in --hive_metastore_uris
The error when running the `kudu hms` with no --hive_metastore_uris flag
did not indicate clearly what the user should do (i.e. pass in the
flag). This adds that clarity.
Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
---
M src/kudu/tools/tool_action_hms.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13578/1
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13578 )
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Jun 2019 22:20:40 +0000
Gerrit-HasComments: No
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13578
to look at the new patch set (#2).
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
hms: clarify message to pass in --hive_metastore_uris
The error when running the `kudu hms` with no --hive_metastore_uris flag
did not indicate clearly what the user should do (i.e. pass in the
flag). This adds that clarity.
Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13578/2
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13578 )
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13578/1/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/13578/1/src/kudu/tools/tool_action_hms.cc@134
PS1, Line 134: Could not fetch the Hive Metastore locations from the Kudu master "
: "since it is
> To make it even clearer, maybe rephrase this sentence:
Done
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Jun 2019 23:26:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13578 )
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13578/1/src/kudu/tools/tool_action_hms.cc
File src/kudu/tools/tool_action_hms.cc:
http://gerrit.cloudera.org:8080/#/c/13578/1/src/kudu/tools/tool_action_hms.cc@134
PS1, Line 134: The Kudu leader master is not configured with the Hive Metastore "
: "integration
To make it even clearer, maybe rephrase this sentence:
Could not get Hive Metastore locations from master since it's not configured for Hive Metastore integration.
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 10 Jun 2019 22:54:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13578 )
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Jun 2019 00:18:03 +0000
Gerrit-HasComments: No
[kudu-CR] hms: clarify message to pass in --hive metastore uris
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13578 )
Change subject: hms: clarify message to pass in --hive_metastore_uris
......................................................................
hms: clarify message to pass in --hive_metastore_uris
The error when running the `kudu hms` with no --hive_metastore_uris flag
did not indicate clearly what the user should do (i.e. pass in the
flag). This adds that clarity.
Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Reviewed-on: http://gerrit.cloudera.org:8080/13578
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_hms.cc
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ec8bcedc8e038cb20f9dd96c929f15429051327
Gerrit-Change-Number: 13578
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)