[GitHub] [superset] corbinrobb commented on pull request #17515: fix(CRUD views): change empty rows layout in TableCollection to be consistent with its headers

[GitBox <gi...@apache.org>]

corbinrobb commented on pull request #17515:
URL: https://github.com/apache/superset/pull/17515#issuecomment-977182909


   Thanks! @lyndsiWilliams 
   
   Here are the screenshots of the difference that you asked for.
   
   Before is with `'xs'` and after is `'sm'`
   
   ### Before with icons:
   <img width="570" alt="Before Shot" src="https://user-images.githubusercontent.com/31329271/143131104-6f2b5061-8cca-4e88-9ec4-105f568f3797.png">
   
   ### After with icons:
   <img width="570" alt="After Shot" src="https://user-images.githubusercontent.com/31329271/143131218-48f40a43-1c9b-448d-94af-0ba365df87f8.png">
   
   ### Before loading with no rows:
   <img width="570" alt="Screen Shot 2021-11-23 at 2 08 25 PM" src="https://user-images.githubusercontent.com/31329271/143131374-13b9a7eb-fe2c-44ee-be6c-ad32dc6d0c1a.png">
   
   ### After loading with no rows:
   <img width="570" alt="Screen Shot 2021-11-23 at 2 10 05 PM" src="https://user-images.githubusercontent.com/31329271/143131436-032cbe4d-98dd-4e6c-867c-889b05599a1d.png">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org