You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "YxYL6125 (via GitHub)" <gi...@apache.org> on 2023/11/12 06:54:21 UTC

[I] [BUG] <`this.doRefreshConfig()` method is not executed after restarting the plugin.> [shenyu]

YxYL6125 opened a new issue, #5292:
URL: https://github.com/apache/shenyu/issues/5292

   ### Is there an existing issue for this?
   
   - [X] I have searched the existing issues
   
   ### Current Behavior
   
   _No response_
   
   ### Expected Behavior
   
   _No response_
   
   ### Steps To Reproduce
   
   When I open the plugin for the first time, there is no deposit inside `Singleton.INST`, so the following code can be executed:
   
   ```java
   this.doRefreshConfig(globalLogConfig);
   logCollector().start();
   ```
   
   ![image-20231112144406521](https://raw.githubusercontent.com/YxYL6125/imgBad/main/img/image-20231112144406521.png)
   
   ![image-20231112144440081](https://raw.githubusercontent.com/YxYL6125/imgBad/main/img/image-20231112144440081.png)
   
   And it is also possible to execute ``this.close0();`` the first time I close it.
   
   ![image-20231112144522677](https://raw.githubusercontent.com/YxYL6125/imgBad/main/img/image-20231112144522677.png)
   
   But when I start the plugin again, the `doRefreshConfig()` method will not be executed since it was saved to `Singleton.INST` the previous time.
   
   ![image-20231112144625084](https://raw.githubusercontent.com/YxYL6125/imgBad/main/img/image-20231112144625084.png)
   
   Also, when closing the plugin, since `isStarted` is not set to `true`, it will not be executed either. This ultimately causes the plugin to fail on subsequent startups and shutdowns.
   
   ![image-20231112144643719](https://raw.githubusercontent.com/YxYL6125/imgBad/main/img/image-20231112144643719.png)
   
   
   
   ### Environment
   
   ```markdown
   ShenYu version(s):2.6.0
   ```
   
   
   ### Debug logs
   
   _No response_
   
   ### Anything else?
   
   My thinking was to `remove` the value inside the `Singleton.INST` when `closing` the plugin. The `doRefreshConfig` method is then executed when the plugin is restarted. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org