You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/08/14 08:45:38 UTC
[GitHub] [tomcat] thomasmey opened a new pull request, #539: JsonAccessLogValve: Add valve for structured logging
thomasmey opened a new pull request, #539:
URL: https://github.com/apache/tomcat/pull/539
Hi,
this adds a AccessLogValve which logs to stderr in JSON format.
sadly the existing code is very entagled in this regards, that the AccessLogElement does cover two functions: formatting and value fetching.
I tricked the existing code to output JSON by try to re-use most existing code/functions.
The result doesn't look to bad, but I'm happy to receive some feedback.
I also left in some comments for questions and ideas that came to my mind while coding.
Happy to hear your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rainerjung commented on pull request #539: JsonAccessLogValve: Add valve for structured logging
Posted by "rainerjung (via GitHub)" <gi...@apache.org>.
rainerjung commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525194171
@thomasmey I added support for all subkeyed patterns like request headers (%i), response headers (%o) etc. You might want to have a look and test it. It is now contained in the heads for all supported branches and will probably be released with the may releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher closed pull request #539: JsonAccessLogValve: Add valve for structured logging
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher closed pull request #539: JsonAccessLogValve: Add valve for structured logging
URL: https://github.com/apache/tomcat/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #539: JsonAccessLogValve: Add valve for structured logging
Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1453257058
I merged this with significant modifications. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] thomasmey commented on pull request #539: JsonAccessLogValve: Add valve for structured logging
Posted by "thomasmey (via GitHub)" <gi...@apache.org>.
thomasmey commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525602662
@rainerjung very nice, many thanks!
I just did test the version which landed in 9.0.74 ...
I will allocate some time next week and do some tests.
As you are also an httpd committer feel free to have a look at:
https://github.com/apache/httpd/pull/353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org