You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/05/25 07:15:35 UTC

[GitHub] wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform

wonook commented on a change in pull request #23: [NEMO-67] Fix Communication Pattern for Beam CoGroupByKey transform
URL: https://github.com/apache/incubator-nemo/pull/23#discussion_r190808251
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/NemoPipelineVisitor.java
 ##########
 @@ -241,6 +241,19 @@ private static BeamCoder getCoderForView(final ViewFn viewFn, final Coder beamIn
    */
   private static DataCommunicationPatternProperty.Value getEdgeCommunicationPattern(final IRVertex src,
                                                                                     final IRVertex dst) {
+    try {
+      final Class<?> constructUnionTableFn = Class.forName(
+          "org.apache.beam.sdk.transforms.join.CoGroupByKey$ConstructUnionTableFn");
+      if (src instanceof OperatorVertex && ((OperatorVertex) src).getTransform() instanceof DoTransform
 
 Review comment:
   Also for this bit of code, why is it that it cannot be included in the if-else statement below?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services