You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by zachary1006 <gi...@git.apache.org> on 2018/07/23 23:28:21 UTC
[GitHub] activemq-artemis pull request #2190: remove extra quotes in Windows script
GitHub user zachary1006 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2190
remove extra quotes in Windows script
A double set of quotation marks were preventing successful Windows
implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zachary1006/activemq-artemis fix-Windows-double-quotes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2190
----
commit a607f93e2918fc81621890ab59e15633e65f5eaa
Author: Zachary Simon <za...@...>
Date: 2018-07-23T23:26:07Z
remove extra quotes in Windows script
A double set of quotation marks were preventing successful Windows
implementation.
----
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by zachary1006 <gi...@git.apache.org>.
Github user zachary1006 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
Thanks, gemmellr. I was also able to manually edit the file and get things working, but we package this software as part of a distribution to clients, and it's not realistic for us to require everyone to find this file and modify it. It seemed like a straightforward issue to fix, so I opened the PR.
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
FWIW, I created a broker instance on Windows with spaces in the directory name, and the broker failed to start using the suggested run command. I then edited the artemis.cmd within the instance directory as suggested here, and after that it started up fine.
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
I was offering a second view that there is an issue requiring a change and noting the proposal worked for me, not suggesting you should just keep modifying it yourself.
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
I just wanted to know the results of the test on windows as I don’t have a box now.
I will merge this.
This is probably 2.6.x as well and I will merge it.
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by zachary1006 <gi...@git.apache.org>.
Github user zachary1006 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
Thanks for having a look at this PR. I ran the tests; the results are attached.
My problem was Windows-specific, though. We could not start Artemis on a Windows machine because the command at line 62 got expanded to:
`set JVM_ARGS=%JVM_ARGS% -Dartemis.instance.etc=""C:/Program Files/File Location""`
This got read in as `-Dartemis.instance.etc=""`, with `C:/Program`, `Files/File`, and `Location` as arguments.
[validate-scripts test results.txt](https://github.com/apache/activemq-artemis/files/2224500/validate-scripts.test.results.txt)
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by zachary1006 <gi...@git.apache.org>.
Github user zachary1006 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
Sorry about pushing to the wrong branch. Thanks for fixing it.
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
The PR should been on master.. and we cherry-pick it into 2.6.x
I used some git-fu to merge it into master.
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
These double quotes were added to deal with directories with space.. they were working fine at the time...
Can you run artemis-distribution/src/test/scripts/validate-scripts.sh after you built your project with your changes?
---
[GitHub] activemq-artemis issue #2190: remove extra quotes in Windows script
Posted by dwickern <gi...@git.apache.org>.
Github user dwickern commented on the issue:
https://github.com/apache/activemq-artemis/pull/2190
```bat
set ARTEMIS_INSTANCE_ETC="${artemis.instance.etc}"
set JVM_ARGS=%JVM_ARGS% -Dartemis.instance.etc="%ARTEMIS_INSTANCE_ETC%"
```
Won't this _always_ result in the path being quoted twice?
```
C:\Users\dwickern>set ARTEMIS_INSTANCE_ETC="path with spaces"
C:\Users\dwickern>set JVM_ARGS=%JVM_ARGS% -Dartemis.instance.etc="%ARTEMIS_INSTA
NCE_ETC%"
C:\Users\dwickern>echo %JVM_ARGS%
%JVM_ARGS% -Dartemis.instance.etc=""path with spaces""
```
---
[GitHub] activemq-artemis pull request #2190: remove extra quotes in Windows script
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2190
---