[GitHub] rabbah opened a new issue #2380: dead code in CLI command line parsing

[gi...@git.apache.org]

rabbah opened a new issue #2380: dead code in CLI command line parsing
URL: https://github.com/apache/incubator-openwhisk/issues/2380
 
 
   I think these lines are currently deadcode:
   * https://github.com/apache/incubator-openwhisk/blob/master/tools/cli/go-whisk-cli/commands/action.go#L884-L887
   * https://github.com/apache/incubator-openwhisk/blob/master/tools/cli/go-whisk-cli/commands/action.go#L898-L901
   * https://github.com/apache/incubator-openwhisk/blob/master/tools/cli/go-whisk-cli/commands/action.go#L904-L905
   
   because the parameter and annotation parsing is happening here instead:
   https://github.com/apache/incubator-openwhisk/blob/master/tools/cli/go-whisk-cli/commands/commands.go#L132
   
   I only checked `actions.go` but suspect since this code is common to triggers and packages, the same will apply there.
   
   Should this code be removed? 
   Also, I code in `commands.go` for parsing annotations and parameters could be refactored for reuse.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services